From: Olof Johansson <olof@lixom.net>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Tomasz Figa <t.figa@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [PATCH v2 6/6] ARM: tegra: cpuidle: use firmware for power down
Date: Tue, 11 Feb 2014 17:36:50 -0800 [thread overview]
Message-ID: <20140212013650.GA7584@quad.lixom.net> (raw)
In-Reply-To: <1391747706-1847-7-git-send-email-acourbot@nvidia.com>
On Fri, Feb 07, 2014 at 01:35:06PM +0900, Alexandre Courbot wrote:
> Attempt to invoke the prepare_idle() and do_idle() firmware calls
> to power down a CPU so an underlying firmware gets informed of
> the idle operation and performs it by itself if designed in such a way.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> arch/arm/mach-tegra/cpuidle-tegra114.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-tegra/cpuidle-tegra114.c b/arch/arm/mach-tegra/cpuidle-tegra114.c
> index e0b87300243d..558067ddc186 100644
> --- a/arch/arm/mach-tegra/cpuidle-tegra114.c
> +++ b/arch/arm/mach-tegra/cpuidle-tegra114.c
> @@ -19,6 +19,7 @@
> #include <linux/cpuidle.h>
> #include <linux/cpu_pm.h>
> #include <linux/clockchips.h>
> +#include <asm/firmware.h>
>
> #include <asm/cpuidle.h>
> #include <asm/suspend.h>
> @@ -45,7 +46,15 @@ static int tegra114_idle_power_down(struct cpuidle_device *dev,
>
> clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu);
>
> - cpu_suspend(0, tegra30_sleep_cpu_secondary_finish);
> + call_firmware_op(prepare_idle);
> +
> + switch (call_firmware_op(do_idle)) {
> + case -ENOSYS:
> + cpu_suspend(0, tegra30_sleep_cpu_secondary_finish);
> + break;
> + default:
> + break;
Do you expect other cases down the road? If not, this is a simple if instead:
/* Only call cpu_suspend if TF didn't handle the pre-suspend logic */
if (call_firmware_op(do_idle) == -ENOSYS)
cpu_suspend(....);
-Olof
next prev parent reply other threads:[~2014-02-12 1:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 4:35 [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 1/6] ARM: trusted_foundations: fix vendor prefix typos Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 2/6] ARM: trusted_foundations: fallback when TF support is missing Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 3/6] ARM: firmware: enable Trusted Foundations by default Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation Alexandre Courbot
2014-02-13 11:01 ` Tomasz Figa
2014-02-13 16:37 ` Stephen Warren
2014-02-14 5:16 ` Alexandre Courbot
2014-02-14 10:42 ` Tomasz Figa
2014-02-07 4:35 ` [PATCH v2 5/6] ARM: trusted_foundations: implement prepare_idle() Alexandre Courbot
2014-02-07 4:35 ` [PATCH v2 6/6] ARM: tegra: cpuidle: use firmware for power down Alexandre Courbot
2014-02-12 1:36 ` Olof Johansson [this message]
2014-02-12 1:56 ` Alexandre Courbot
2014-02-12 2:43 ` [PATCH v3] " Alexandre Courbot
2014-02-12 20:04 ` Olof Johansson
2014-02-12 1:38 ` [PATCH v2 0/6] ARM: firmware: improvements to Trusted Foundations support Olof Johansson
2014-02-12 20:07 ` Stephen Warren
2014-02-18 20:56 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212013650.GA7584@quad.lixom.net \
--to=olof@lixom.net \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox