From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Jean Delvare <jdelvare@suse.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v6] mfd: MAX6650/6651 support
Date: Wed, 12 Feb 2014 08:32:24 +0000 [thread overview]
Message-ID: <20140212083224.GM15081@lee--X1> (raw)
In-Reply-To: <CAOMwXhNp-+Fr87NxdquEOtEriqt20E4b08W8JBrKMbCqh1K6_Q@mail.gmail.com>
> >> + max665x->map = devm_regmap_init_i2c(i2c, &max665x_regmap_config);
> >
> > Don't you need to check the return value of devm_regmap_init_i2c?
>
> I personally think I should. I strived for consistency though with
> other similar drivers. After this many reviews about such things, it
> seems that consistency matters here less than other projects which I
> can cope with, thanks.
The right thing to do is normally preferred.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-12 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 4:02 [PATCH v6] mfd: MAX6650/6651 support Laszlo Papp
2014-02-12 4:42 ` Sachin Kamat
2014-02-12 7:06 ` Laszlo Papp
2014-02-12 8:32 ` Lee Jones [this message]
2014-02-12 9:34 ` Laszlo Papp
2014-02-12 17:50 ` Mark Brown
2014-02-13 8:23 ` Lee Jones
2014-02-13 9:14 ` Laszlo Papp
2014-02-13 10:26 ` Mark Brown
2014-02-13 10:34 ` Laszlo Papp
2014-02-14 9:02 ` Laszlo Papp
2014-02-14 10:19 ` Lee Jones
2014-02-14 10:59 ` Laszlo Papp
2014-02-14 20:57 ` Mark Brown
2014-02-17 8:55 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212083224.GM15081@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jdelvare@suse.de \
--cc=k.kozlowski@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpapp@kde.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox