From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbaBLKQw (ORCPT ); Wed, 12 Feb 2014 05:16:52 -0500 Received: from mail-wi0-f178.google.com ([209.85.212.178]:57800 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbaBLKQs (ORCPT ); Wed, 12 Feb 2014 05:16:48 -0500 Date: Wed, 12 Feb 2014 10:16:42 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mfd: 88pm800: Fix I2C device resource leak if probe fails Message-ID: <20140212101642.GY15081@lee--X1> References: <20140212095828.GW15081@lee--X1> <1392199856-25412-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1392199856-25412-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Feb 2014, Krzysztof Kozlowski wrote: > During probe the driver allocates two dummy I2C devices for subchips in > function pm800_pages_init(). Additionally this function allocates > regmaps for these subchips. If any of these steps fail then these dummy > I2C devices are not freed and resources leak. > > On pm800_pages_init() fail the driver must call pm800_pages_exit() to > unregister dummy I2C devices. > > Signed-off-by: Krzysztof Kozlowski > Cc: stable@vger.kernel.org > --- > drivers/mfd/88pm800.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog