From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Rientjes <rientjes@google.com>
Cc: dl9pf@gmx.de, Behan Webster <behanw@converseincode.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI
Date: Wed, 12 Feb 2014 22:01:16 +0000 [thread overview]
Message-ID: <20140212220116.GR18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1402121351510.27082@chino.kir.corp.google.com>
On Wed, Feb 12, 2014 at 01:54:43PM -0800, David Rientjes wrote:
> So this patch is only as a courtesy to clang and you're not complaining
> about things like __builtin() functions, typeof, or a ? : b conditional
> operators because clang happens to support them?
That patch removes a disgusting construct; who cares how they'd discovered
it? Consider it courtesy to reviewers, clang or no clang...
Folks, it's C; no need to bring Pascal misfeatures in, even if gcc happens
to accept them.
next prev parent reply other threads:[~2014-02-12 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 20:58 [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI dl9pf
2014-02-12 21:11 ` Christoph Hellwig
2014-02-12 21:20 ` Behan Webster
2014-02-12 21:27 ` Måns Rullgård
2014-02-12 21:32 ` Richard Weinberger
2014-02-12 21:54 ` David Rientjes
2014-02-12 22:01 ` Al Viro [this message]
2014-02-13 13:03 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212220116.GR18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=David.Woodhouse@intel.com \
--cc=behanw@converseincode.com \
--cc=dl9pf@gmx.de \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox