From: Richard Cochran <richardcochran@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: stefan.sorensen@spectralink.com, grant.likely@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 0/3] dp83640: Get pin and master/slave configuration from DT
Date: Fri, 14 Feb 2014 10:06:01 +0100 [thread overview]
Message-ID: <20140214090601.GA3906@netboy> (raw)
In-Reply-To: <20140213.173957.2126489785330496380.davem@davemloft.net>
On Thu, Feb 13, 2014 at 05:39:57PM -0500, David Miller wrote:
> You'll have to code this in a way such that people who currently specify
> this parameter keep working.
So, do module parameters count as user land ABI?
[ In any case, for this module, there must be a way to retain the
parameters and still offer DT, and letting DT have precedence. ]
People want to be able to configure the auxiliary functions on the
pins of their PTP devices. My preference for supporting this is:
1. additional ioctl on the PTP character device
2. ethtool ioctl
3. DT and/or ACPI
The first option seems best because that is how you activate the
auxiliary functions. I am working on something in this direction.
Can't we just drop the DT idea altogther?
> If you don't like it, be angry at whoever added this module parameter
> in the first place, not me. Module parameters are 99 times out of 100
> not the right way to configure something, really.
Yeah, I am the one, be angry with me.
Sorry,
Richard
next prev parent reply other threads:[~2014-02-14 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 14:35 [PATCH v3 0/3] dp83640: Get pin and master/slave configuration from DT Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 1/3] net:phy:dp83640: Program pulsewidth2 values of perout triggers 0 and 1 Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 2/3] net:phy:dp83640: Support a configurable number of periodic outputs Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 3/3] net:phy:dp83640: Get pin and master/slave configuration from DT Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 0/3] dp83640: " Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 1/3] net:phy:dp83640: Program pulsewidth2 values of perout triggers 0 and 1 Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 2/3] net:phy:dp83640: Support a configurable number of periodic outputs Stefan Sørensen
2014-02-13 14:35 ` [PATCH v3 3/3] net:phy:dp83640: Get pin and master/slave configuration from DT Stefan Sørensen
2014-02-13 22:39 ` [PATCH v3 0/3] dp83640: " David Miller
2014-02-14 9:06 ` Richard Cochran [this message]
2014-02-14 18:36 ` David Miller
2014-03-10 13:54 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214090601.GA3906@netboy \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox