Re: [char-misc-next 3/4] mei: add mei_hbuf_acquire wrapper

Greg KH
2014-02-14T19:12:19Z

On Wed, Feb 12, 2014 at 09:41:53PM +0200, Tomas Winkler wrote:
> A client has to acquire host buffer
> before writing, we add lock like wrapper
> to replace the code snippet
>
> if (dev->hbuf_is_ready)
> dev->hbuf_is_ready = false;
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/amthif.c | 7 +-----
> drivers/misc/mei/client.c | 56 ++++++++++++++++++++++++++++----------------
> drivers/misc/mei/hw-me.c | 2 ++
> drivers/misc/mei/hw-txe.c | 17 +++++---------
> drivers/misc/mei/interrupt.c | 6 ++---
> drivers/misc/mei/mei_dev.h | 2 ++
> drivers/misc/mei/wd.c | 14 +++++------
> 7 files changed, 57 insertions(+), 47 deletions(-)

This patch fails to apply:
checking file drivers/misc/mei/amthif.c
checking file drivers/misc/mei/client.c
Hunk #4 FAILED at 681.
Hunk #5 succeeded at 815 (offset -2 lines).
Hunk #6 succeeded at 848 (offset -2 lines).
1 out of 6 hunks FAILED
checking file drivers/misc/mei/hw-me.c
checking file drivers/misc/mei/hw-txe.c
checking file drivers/misc/mei/interrupt.c
checking file drivers/misc/mei/mei_dev.h
checking file drivers/misc/mei/wd.c