From: Dan Carpenter <dan.carpenter@oracle.com>
To: Levente Kurusa <levex@linux.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
OSUOSL Drivers <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check
Date: Sat, 15 Feb 2014 13:36:23 +0300 [thread overview]
Message-ID: <20140215103623.GE26722@mwanda> (raw)
In-Reply-To: <52FF1CFE.40504@linux.com>
On Sat, Feb 15, 2014 at 08:53:34AM +0100, Levente Kurusa wrote:
> Thanks Dan, maybe you know some people who could test it?
> RTLXXXXXX guys? Or maybe we can take the patch as is?
> I cannot really think of any other solution other than removing
> the other clause, but since that was written to the file,
> there must have been some logic behind that. I am slightly
> disappointed get_maintainer didn't really find anybody for
> this patch...
This driver is going to be deleted in the next couple weeks and replaced
with a re-written from scratch driver.
Your fix is correct. It's just that no one tested the AP code for this.
I would feel comfortable applying it as-is if no one is available to
test it.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-15 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 21:50 [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check Levente Kurusa
2014-02-14 22:00 ` Dan Carpenter
2014-02-15 7:53 ` Levente Kurusa
2014-02-15 10:36 ` Dan Carpenter [this message]
2014-02-15 10:56 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215103623.GE26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox