Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file

Jassi Brar
2014-02-16T06:38:25Z

On Sun, Feb 16, 2014 at 12:46 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote:
>> From: Suman Anna <s-anna@ti.com>
>>
>> This is needed for extracting the omap_mbox. The OMAP mailbox
>> code has a need for exporting some pre-existing API to not
>> break the current clients.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> drivers/mailbox/mailbox.c | 62 +-----------------------------
>> drivers/mailbox/mailbox_internal.h | 77 ++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 78 insertions(+), 61 deletions(-)
>> create mode 100644 drivers/mailbox/mailbox_internal.h
>
> Also, this patch doesn't seem to be needed at all here, nothing breaks
> without it, so why include it in this series?
>
Suman had to segregate the definitions temporarily while the TI
drivers were sorted out. I hope Suman says the patch isn't needed
anymore :)

Thanks,
Jassi