Re: [PATCHv3 2/6] mailbox: Introduce a new common API

Greg KH
2014-02-15T19:03:15Z

On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote:
> +typedef unsigned request_token_t;

Ick. Why add a new typedef? And if you do need this, drop the "_t" on
the end please.

Why not just rely on an unsigned int? Or long? Do you really need a
new type?

thanks,

greg k-h