public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Ingo Molnar <mingo@kernel.org>, Dave Jones <davej@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: sched: fair: NULL ptr deref in check_preempt_wakeup
Date: Sun, 16 Feb 2014 20:19:09 +0100	[thread overview]
Message-ID: <20140216191909.GL14089@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52FFF7F8.2070801@oracle.com>

On Sat, Feb 15, 2014 at 06:27:52PM -0500, Sasha Levin wrote:
> Hi folks,
> 
> While fuzzing with trinity inside a KVM tools guest running latest -next kernel, I've
> stumbled on the following:
> 
> [  522.645288] BUG: unable to handle kernel NULL pointer dereference at 0000000000000150
> [  522.646271] IP: [<ffffffff81186c6f>] check_preempt_wakeup+0x11f/0x210
> 
> Since it's pretty inlined, the code points to:
> 
> 	check_preempt_wakeup()
> 		find_matching_se()
> 			find_matching_se()
> 				check_preempt_wakeup()
> 
> 
> 	static inline struct cfs_rq *
> 	is_same_group(struct sched_entity *se, struct sched_entity *pse)
> 	{
> 	        if (se->cfs_rq == pse->cfs_rq)	<=== HERE
> 	                return se->cfs_rq;
> 	
> 	        return NULL;
> 	}

Hrm.. that means we got se->depth wrong. I'll have a poke tomorrow.

  parent reply	other threads:[~2014-02-16 19:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 23:27 sched: fair: NULL ptr deref in check_preempt_wakeup Sasha Levin
2014-02-15 23:32 ` Sasha Levin
2014-02-16 19:19 ` Peter Zijlstra [this message]
2014-02-17  8:11 ` Michael wang
2014-02-17  9:20   ` Peter Zijlstra
2014-02-18  2:26     ` Michael wang
2014-02-19 18:10       ` Sasha Levin
2014-02-19 18:37         ` Peter Zijlstra
2014-02-20  2:22         ` Michael wang
2014-02-17 21:07   ` Sasha Levin
2014-02-18  2:28     ` Michael wang
2014-02-19 16:16   ` Peter Zijlstra
2014-02-20  2:18     ` Michael wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140216191909.GL14089@laptop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox