public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	mingo@kernel.org, eranian@google.com,
	linux-kernel@vger.kernel.org,
	Markus Metzger <markus.t.metzger@intel.com>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, nmi: fix unknown NMI warning
Date: Sun, 16 Feb 2014 20:43:30 +0100	[thread overview]
Message-ID: <20140216194330.GE32005@two.firstfloor.org> (raw)
In-Reply-To: <20140216192312.GM14089@laptop.programming.kicks-ass.net>


The best APIC documentation are the old data sheets for the external
APIC chips. I don't know if they cover things in such detail.

> In this case the latter NMI will actually have an overflow state to
> process so it's not a spurious NMI.

But we cannot distinguish it right? The spurious detector would
trigger in any case.

> 
> > And if we're in a state that PMIs get re-raised quickly, we should either
> > regulate the period down or start throttling.
> 
> It could be a different counter; where both run at 'normal' periods but
> just near miss each other by accident.

That's true.

It would be only a problem if they somehow become synchronized that
this happens very commonly. The usual defense against things like 
that is to add a little randomization (I remember Stephane had
a patch for that some time ago). Also I believe it helps to have
the periods be prime numbers. But right now don't have any evidence
it's a real problem. I presume there's enough noise on a typical
setup that any such states disappear again quickly enough.

-Andi

  reply	other threads:[~2014-02-16 19:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15  0:44 [PATCH] perf, nmi: fix unknown NMI warning Andi Kleen
2014-02-15  9:58 ` Peter Zijlstra
2014-02-16 18:38   ` Andi Kleen
2014-02-16 19:23     ` Peter Zijlstra
2014-02-16 19:43       ` Andi Kleen [this message]
2014-02-21 21:14 ` [tip:perf/urgent] perf, nmi: Fix " tip-bot for Markus Metzger
  -- strict thread matches above, loose matches on Subject: below --
2014-02-11 23:51 [PATCH] perf, nmi: fix " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140216194330.GE32005@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox