From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbaBPXXp (ORCPT ); Sun, 16 Feb 2014 18:23:45 -0500 Received: from ec2-54-201-57-178.us-west-2.compute.amazonaws.com ([54.201.57.178]:59992 "EHLO ip-172-31-12-36.us-west-2.compute.internal" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751197AbaBPXXo (ORCPT ); Sun, 16 Feb 2014 18:23:44 -0500 X-Greylist: delayed 508 seconds by postgrey-1.27 at vger.kernel.org; Sun, 16 Feb 2014 18:23:44 EST Date: Sun, 16 Feb 2014 23:14:07 +0000 From: dwalker@fifo99.com To: Paul Bolle Cc: David Brown , Bryan Huntsman , Russell King , Richard Weinberger , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: msm: remove MACH_MSM7X30_SURF Message-ID: <20140216231407.GA18892@fifo99.com> References: <1392572080.28866.19.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392572080.28866.19.camel@x220> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 16, 2014 at 06:34:40PM +0100, Paul Bolle wrote: > The Kconfig symbol MACH_MSM7X30_SURF was added in v2.6.35. It has never > been used. Setting it has no effect. There are no calls for > machine_is_mach_msm7x30(). This symbol can safely be removed. > > Signed-off-by: Paul Bolle > --- > Tested only with "git grep". > > arch/arm/mach-msm/Kconfig | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig > index 9625cf3..dab941a 100644 > --- a/arch/arm/mach-msm/Kconfig > +++ b/arch/arm/mach-msm/Kconfig > @@ -62,7 +62,6 @@ config ARCH_MSM7X30 > select ARCH_MSM_SCORPION > select CPU_V7 > select GPIO_MSM_V1 > - select MACH_MSM7X30_SURF # if ! > select MSM_GPIOMUX > select MSM_PROC_COMM > select MSM_SMD > @@ -115,12 +114,6 @@ config MACH_TROUT > help > Support for the HTC Dream, T-Mobile G1, Android ADP1 devices. > > -config MACH_MSM7X30_SURF > - depends on ARCH_MSM7X30 > - bool "MSM7x30 SURF" > - help > - Support for the Qualcomm MSM7x30 SURF eval board. > - It's not really enough .. There are support files for this platform, if you remove it you need to remove those files also. You could also go the other way and connect the config option to those files. Daniel