From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Jenny Tc <jenny.tc@intel.com>
Subject: Re: [PATCH v3 14/15] charger: max14577: Configure battery-dependent settings from DTS
Date: Mon, 17 Feb 2014 10:07:35 +0000 [thread overview]
Message-ID: <20140217100735.GA20218@lee--X1> (raw)
In-Reply-To: <1392627950-26927-15-git-send-email-k.kozlowski@samsung.com>
> diff --git a/include/linux/mfd/max14577-private.h b/include/linux/mfd/max14577-private.h
> index a8cd7de3526a..fc69d7beb1aa 100644
> --- a/include/linux/mfd/max14577-private.h
> +++ b/include/linux/mfd/max14577-private.h
> @@ -269,6 +269,20 @@ enum maxim_muic_charger_type {
> #define MAX77836_CHARGER_CURRENT_LIMIT_HIGH_STEP 25000U
> #define MAX77836_CHARGER_CURRENT_LIMIT_MAX 475000U
>
> +/* MAX14577 charger End-Of-Charge current limits
> + * (as in MAXIM_CHGCTRL5 register), uA
> + */
> +#define MAX14577_CHARGER_EOC_CURRENT_LIMIT_MIN 50000U
> +#define MAX14577_CHARGER_EOC_CURRENT_LIMIT_STEP 10000U
> +#define MAX14577_CHARGER_EOC_CURRENT_LIMIT_MAX 200000U
> +
> +/* MAX14577/MAX77836 Battery Constant Voltage
> + * (as in MAXIM_CHGCTRL3 register), uV
> + */
These are not proper multi-line comments.
Documentation/CodingSytle:
The preferred style for long (multi-line) comments is:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-17 10:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 9:05 [PATCH v3 00/15] mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 01/15] extcon: max14577: Change extcon name instead of static name according to device type Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 02/15] mfd: max14577: Rename and add MAX14577 symbols to prepare for max77836 Krzysztof Kozlowski
2014-02-19 12:44 ` Krzysztof Kozlowski
2014-02-19 14:11 ` Mark Brown
2014-02-20 8:54 ` Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 03/15] mfd: max14577: Rename state container to maxim_core Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 04/15] mfd: max14577: Add "muic" suffix to regmap and irq_chip Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 05/15] mfd: max14577: Add detection of device type Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 06/15] extcon: max14577: Add max14577 prefix to muic_irqs Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 07/15] extcon: max14577: Choose muic_irqs according to device type Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 08/15] mfd: max77836: Add max77836 support to max14577 driver Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 09/15] extcon: max14577: Add support for max77836 Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 10/15] regulator: max14577: Add support for max77836 regulators Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 11/15] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 12/15] power: max17040: Add ID for max77836 Fuel Gauge block Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 13/15] regulator/mfd: max14577: Export symbols for calculating charger current Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 14/15] charger: max14577: Configure battery-dependent settings from DTS Krzysztof Kozlowski
2014-02-17 10:07 ` Lee Jones [this message]
2014-02-17 10:40 ` Krzysztof Kozlowski
2014-02-17 11:22 ` Lee Jones
2014-02-20 6:30 ` Jenny Tc
2014-02-20 8:43 ` Krzysztof Kozlowski
2014-02-17 9:05 ` [PATCH v3 15/15] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2014-02-19 15:12 ` Tomasz Figa
2014-02-19 15:17 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217100735.GA20218@lee--X1 \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jenny.tc@intel.com \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox