Re: [PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of data integrity write

Tejun Heo
2014-03-14T14:20:41Z

On Fri, Mar 14, 2014 at 11:17:56PM +0900, Roman Peniaev wrote:
> No, no. Not device does not support flush, filesystem does not care about flush.
> (take any old school, e.g. ext2)
>
> We did some write, and then we did fsync.
> But filesystem does not support REQ_FLUSH/FUA so block device will never
> get the checkpoint where it should really flush everything.
>
> So, fsync will not guarantee any integrity in that case.

Oh, no idea. Fix the filesystem to support REQ_FLUSH? :)

--
tejun