From: David Cohen <david.a.cohen@linux.intel.com>
To: sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM
Date: Tue, 18 Feb 2014 10:00:30 -0800 [thread overview]
Message-ID: <20140218180030.GA10029@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <1389063739-6028-1-git-send-email-david.a.cohen@linux.intel.com>
Hi Sarah,
On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote:
> When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this
> warning:
> drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined
> but not used [-Wunused-function]
>
> It happens due to lack of __maybe_unused flag on xhci_msix_sync_irqs()
> function in case of !CONFIG_PCI.
>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> ---
Ping :)
Any comments here?
Br, David
>
> Change v1 -> v2:
> - xhci_msix_sync_irqs() already uses __maybe_unused flag when CONFIG_PCI is
> set. Proper solution is to add same flag when !CONFIG_PCI instead of define
> function as inline.
>
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 4265b48856f6..ed6b717b8ee1 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -406,7 +406,7 @@ static void xhci_cleanup_msix(struct xhci_hcd *xhci)
> {
> }
>
> -static void xhci_msix_sync_irqs(struct xhci_hcd *xhci)
> +static void __maybe_unused xhci_msix_sync_irqs(struct xhci_hcd *xhci)
> {
> }
>
> --
> 1.8.4.2
next prev parent reply other threads:[~2014-02-18 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 1:44 [PATCH] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM David Cohen
2014-01-07 3:02 ` [PATCH v2] " David Cohen
2014-02-18 18:00 ` David Cohen [this message]
2014-02-18 18:47 ` Felipe Balbi
2014-02-18 19:04 ` David Cohen
2014-03-21 21:41 ` David Cohen
2014-03-24 11:44 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218180030.GA10029@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox