Re: [PATCH 01/14] staging: binder: Fix death notifications

Greg KH
2014-02-18T19:31:49Z

On Tue, Feb 18, 2014 at 11:21:24AM -0800, John Stultz wrote:
> On Tue, Feb 18, 2014 at 11:02 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Feb 17, 2014 at 01:58:29PM -0800, John Stultz wrote:
> >> From: Arve Hjønnevåg <arve@android.com>
> >>
> >> The change (008fa749e0fe5b2fffd20b7fe4891bb80d072c6a) that moved the
> >> node release code to a separate function broke death notifications in
> >> some cases. When it encountered a reference without a death
> >> notification request, it would skip looking at the remaining
> >> references, and therefore fail to send death notifications for them.
> >>
> >> Cc: Greg KH <gregkh@linuxfoundation.org>
> >> Cc: Colin Cross <ccross@android.com>
> >> Cc: Arve Hjønnevåg <arve@android.com>
> >> Cc: Android Kernel Team <kernel-team@android.com>
> >> Signed-off-by: Arve Hjønnevåg <arve@android.com>
> >> Signed-off-by: John Stultz <john.stultz@linaro.org>
> >> ---
> >> drivers/staging/android/binder.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > As this broke in 3.10, shouldn't this go to staging-linus and get
> > backported to the stable trees too?
>
> Right. I rearranged this fix to be in the front of this series because
> of this, and mentioned in the cover letter that it might be considered
> for 3.14. If that's considered ok, then it can be pushed to stable as
> well.

I never read 00/ emails because they will never show up in the kernel
changelog :)

I'll go queue this up for 3.14-final and the stable trees.

thanks,

greg k-h