From: "J. Bruce Fields" <bfields@fieldses.org>
To: "J. R. Okajima" <hooanon05g@gmail.com>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
Jeff Layton <jlayton@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()
Date: Tue, 18 Feb 2014 15:44:38 -0500 [thread overview]
Message-ID: <20140218204438.GA12930@fieldses.org> (raw)
In-Reply-To: <20699.1392737273@jrobl>
On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote:
>
> There is a regression in
> 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate
> which deletes an nfserrno() call in nfsd_setattr() (by accident,
> probably), and NFSD becomes ignoring an error from VFS.
>
> Here is a patch to fix it.
Thanks for cathing that! Queueing up for 3.14.
--b.
>
> J. R. Okajima
>
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 017d3cb..6d7be3f 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -449,6 +449,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
> fh_lock(fhp);
> host_err = notify_change(dentry, iap, NULL);
> fh_unlock(fhp);
> + err = nfserrno(host_err);
>
> out_put_write_access:
> if (size_change)
next prev parent reply other threads:[~2014-02-18 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 15:27 [PATCH] NFSD, lost nfserrno() call in nfsd_setattr() J. R. Okajima
2014-02-18 20:44 ` J. Bruce Fields [this message]
2014-03-25 8:19 ` J. R. Okajima
2014-03-25 20:41 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218204438.GA12930@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=hooanon05g@gmail.com \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox