* [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()
@ 2014-02-18 15:27 J. R. Okajima
2014-02-18 20:44 ` J. Bruce Fields
0 siblings, 1 reply; 4+ messages in thread
From: J. R. Okajima @ 2014-02-18 15:27 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: Jeff Layton, linux-kernel
There is a regression in
208d0ac 2014-01-07 nfsd4: break only delegations when appropriate
which deletes an nfserrno() call in nfsd_setattr() (by accident,
probably), and NFSD becomes ignoring an error from VFS.
Here is a patch to fix it.
J. R. Okajima
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 017d3cb..6d7be3f 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -449,6 +449,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
fh_lock(fhp);
host_err = notify_change(dentry, iap, NULL);
fh_unlock(fhp);
+ err = nfserrno(host_err);
out_put_write_access:
if (size_change)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()
2014-02-18 15:27 [PATCH] NFSD, lost nfserrno() call in nfsd_setattr() J. R. Okajima
@ 2014-02-18 20:44 ` J. Bruce Fields
2014-03-25 8:19 ` J. R. Okajima
0 siblings, 1 reply; 4+ messages in thread
From: J. Bruce Fields @ 2014-02-18 20:44 UTC (permalink / raw)
To: J. R. Okajima; +Cc: J. Bruce Fields, Jeff Layton, linux-kernel
On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote:
>
> There is a regression in
> 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate
> which deletes an nfserrno() call in nfsd_setattr() (by accident,
> probably), and NFSD becomes ignoring an error from VFS.
>
> Here is a patch to fix it.
Thanks for cathing that! Queueing up for 3.14.
--b.
>
> J. R. Okajima
>
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 017d3cb..6d7be3f 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -449,6 +449,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap,
> fh_lock(fhp);
> host_err = notify_change(dentry, iap, NULL);
> fh_unlock(fhp);
> + err = nfserrno(host_err);
>
> out_put_write_access:
> if (size_change)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()
2014-02-18 20:44 ` J. Bruce Fields
@ 2014-03-25 8:19 ` J. R. Okajima
2014-03-25 20:41 ` J. Bruce Fields
0 siblings, 1 reply; 4+ messages in thread
From: J. R. Okajima @ 2014-03-25 8:19 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: J. Bruce Fields, Jeff Layton, linux-kernel
"J. Bruce Fields":
> On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote:
> >
> > There is a regression in
> > 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate
> > which deletes an nfserrno() call in nfsd_setattr() (by accident,
> > probably), and NFSD becomes ignoring an error from VFS.
> >
> > Here is a patch to fix it.
>
> Thanks for cathing that! Queueing up for 3.14.
Now rc8 is released, but this patch is still un-merged.
The bug is actually a show-stopper for my local tests.
Do you really have a plan to do it? Or should I ask Linus Torvalds
directly?
J. R. Okajima
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NFSD, lost nfserrno() call in nfsd_setattr()
2014-03-25 8:19 ` J. R. Okajima
@ 2014-03-25 20:41 ` J. Bruce Fields
0 siblings, 0 replies; 4+ messages in thread
From: J. Bruce Fields @ 2014-03-25 20:41 UTC (permalink / raw)
To: J. R. Okajima; +Cc: J. Bruce Fields, Jeff Layton, linux-kernel
On Tue, Mar 25, 2014 at 05:19:02PM +0900, J. R. Okajima wrote:
>
> "J. Bruce Fields":
> > On Wed, Feb 19, 2014 at 12:27:53AM +0900, J. R. Okajima wrote:
> > >
> > > There is a regression in
> > > 208d0ac 2014-01-07 nfsd4: break only delegations when appropriate
> > > which deletes an nfserrno() call in nfsd_setattr() (by accident,
> > > probably), and NFSD becomes ignoring an error from VFS.
> > >
> > > Here is a patch to fix it.
> >
> > Thanks for cathing that! Queueing up for 3.14.
>
> Now rc8 is released, but this patch is still un-merged.
> The bug is actually a show-stopper for my local tests.
> Do you really have a plan to do it? Or should I ask Linus Torvalds
> directly?
If you remember, just bug me once a week or so. Snd then if it gets
this late, yes, sending straight to Linus with a cc: to the unresponsive
maintainer and any relevant mailing list is probably a reasonable thing
to do in this sort of situation.
Anyway, my screwup, apologies for not getting that merged at the start.
--b.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-25 20:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 15:27 [PATCH] NFSD, lost nfserrno() call in nfsd_setattr() J. R. Okajima
2014-02-18 20:44 ` J. Bruce Fields
2014-03-25 8:19 ` J. R. Okajima
2014-03-25 20:41 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox