Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

Wolfram Sang
2014-03-06T13:17:39Z

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

On Thu, Mar 06, 2014 at 01:13:55PM +0000, David Howells wrote:
> David Howells <dhowells@redhat.com> wrote:
>
> > > Can we have something like this for 'flags'?
> >
> > There's a __print_flags() which should work. One thing I'm concerned about
> > there is how do we handle more flags being added - does that count as an ABI
> > break if the printed format changes?
> >
> > SMBus flags are basically the same as I2C flags, right?
>
> Hmmm... __print_flags() seems to append a string if a flag is set, and doesn't
> if it isn't set. It places a separator between each string. I would prefer
> something that emits a single char per flag or a dash if it isn't present.
> Are you okay with that?

Yes, that's good, too!

Thanks!

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]