Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

Wolfram Sang
2014-02-28T21:18:08Z

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

> > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or
> > %*phD at least?
>
> My problem with that is that it increases the length of the output by 50% and
> there's a hard limit on how much output we may produce.

Is it PAGE_SIZE? How is this handled when the buffer is so big that the
limit will be reached anyhow? Note that it is really uncommon to
transfer kilobytes in one go via i2c. Usually, big transfers are split
up into smaller fragments, say 128-256 byte. So, for readability, I'd
still favour %*ph.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]