Re: [PATCH 01/21] perf c2c: Shared data analyser

[Don Zickus <dzickus@redhat.com>]

On Tue, Feb 18, 2014 at 09:56:47AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Feb 18, 2014 at 01:52:06PM +0100, Jiri Olsa escreveu:
> > On Mon, Feb 10, 2014 at 12:28:56PM -0500, Don Zickus wrote:
> > > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> <SNIP>
> 
> > > +++ b/tools/perf/util/evlist.h
> > > @@ -52,6 +52,13 @@ struct perf_evsel_str_handler {
> > >  	void	   *handler;
> > >  };
> > >  
> > > +int __perf_evlist__set_handlers(struct perf_evlist *evlist,
> > > +				const struct perf_evsel_str_handler *assocs,
> > > +				size_t nr_assocs);
> > > +
> > > +#define perf_evlist__set_handlers(evlist, array) \
> > > +	__perf_evlist__set_handlers(evlist, array, ARRAY_SIZE(array))
> > > +
> > 
> > this is already implemented in session object.. just need to be
> > changed to work over any event is globaly usable
> 
> This probably has some historical baggage, i.e. I introduced this in
> this cset and later brought it to the trunk, perhaps, need to review
> this to figure this out, busy right now.

No worries, I will dig into it and try to use the right function calls.

Cheers,
Don