From: Lee Jones <lee.jones@linaro.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Michal Simek <monstr@monstr.eu>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, broonie@kernel.org
Subject: Re: [RFC PATCH v2 1/2] mfd: syscon: Support early initialization
Date: Wed, 19 Feb 2014 11:41:32 +0000 [thread overview]
Message-ID: <20140219114132.GC10504@lee--X1> (raw)
In-Reply-To: <fa3178534fcf4488fc45a9a24e44b2588acb38c6.1392807832.git.michal.simek@xilinx.com>
FAO Arnd, Mark,
> Some platforms need to get system controller
> ready as soon as possible.
> The patch provides early_syscon_initialization
> which create early mapping for all syscon compatible
> devices in early_syscon_probe.
> Regmap is get via syscon_early_regmap_lookup_by_phandle()
>
> Regular device probes attach device to regmap
> via regmap_attach_dev().
>
> For early syscon initialization is necessary to extend
> struct syscon and provide remove function
> which unmap all early init structures.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Fix bad logic in early_syscon_probe
> - Fix compilation failure for x86_64 reported by zero day testing system
> - Regmap change available here
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/nodev
>
> drivers/mfd/syscon.c | 128 +++++++++++++++++++++++++++++++++++++++------
> include/linux/mfd/syscon.h | 11 ++++
> 2 files changed, 122 insertions(+), 17 deletions(-)
I have the same reservations as last time:
http://archive.arm.linux.org.uk/lurker/message/20140212.095424.96cb7281.html
I believe you were waiting for Arnd and/or Mark to comment.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-19 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 11:04 [RFC PATCH v2 0/2] Syscon early initialization Michal Simek
2014-02-19 11:04 ` [RFC PATCH v2 1/2] mfd: syscon: Support " Michal Simek
2014-02-19 11:14 ` Alexander Shiyan
2014-02-19 11:16 ` Alexander Shiyan
2014-02-19 11:41 ` Lee Jones [this message]
2014-02-19 11:44 ` Michal Simek
2014-02-19 12:17 ` Mark Brown
2014-02-19 13:51 ` Michal Simek
2014-02-19 13:59 ` Mark Brown
2014-05-09 12:13 ` Tushar Behera
2014-02-19 11:04 ` [RFC PATCH v2 2/2] ARM: zynq: Use early syscon initialization Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219114132.GC10504@lee--X1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox