Re: [workqueue] BUG: unable to handle kernel paging request at ffff880000798f60

Peter Zijlstra
2014-02-19T12:46:19Z

On Wed, Feb 19, 2014 at 08:41:22PM +0800, Fengguang Wu wrote:
> Greetings,
>
> I got the below dmesg and the first bad commit is
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git
>
> commit 84604340d034a074036e86e85c4055a1c7ea5529
> Author: Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Tue Feb 11 12:00:36 2014 +0100
> Commit: Tejun Heo <tj@kernel.org>
> CommitDate: Tue Feb 11 10:25:17 2014 -0500
>
> workqueue: Fix workqueue lockdep name
>
> Tommi noticed a 'funny' lock class name: "%s#5" from a lock acquired
> in process_one_work(). It turns out that commit b196be89cdc14 forgot
> to change the lockdep_init_map() when it changed the @lock_name
> argument from a string to a format.
>
> Fixes: b196be89cdc14 ("workqueue: make alloc_workqueue() take printf
> fmt and args for name")
>
> Reported-by: Tommi Rantala <tt.rantala@gmail.com>
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: stable@vger.kernel.org

I seem to remember tj already having reverted this patch.