From: Vivek Goyal <vgoyal@redhat.com>
To: Jon Mason <jdmason@kudzu.us>
Cc: WANG Chao <chaowang@redhat.com>,
Muli Ben-Yehuda <muli@il.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>,
kexec@lists.infradead.org, discuss@x86-64.org, x86@kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: How could we get rid of saved_max_pfn for calgary iommu?
Date: Wed, 19 Feb 2014 21:36:22 -0500 [thread overview]
Message-ID: <20140220023622.GD2970@redhat.com> (raw)
In-Reply-To: <CAPoiz9yuLg4exX58bh5=XumgAmYNq-9kPjc+f1wa8kMU3-dBbg@mail.gmail.com>
On Wed, Feb 19, 2014 at 05:04:22PM -0700, Jon Mason wrote:
> On Tue, Feb 18, 2014 at 11:18 PM, WANG Chao <chaowang@redhat.com> wrote:
> > Hi, All
> >
> > arch/x86/kernel/pci-calgary.c is the only user of saved_max_pfn today:
> >
> > int __init detect_calgary(void)
> > {
> > [..]
> > specified_table_size = determine_tce_table_size((is_kdump_kernel() ?
> > saved_max_pfn : max_pfn) * PAGE_SIZE);
> > [..]
> > }
>
> IIUC, the purpose of this code is to reuse the TCE table from the
> previous kernel. Thus, it needs to be of the same size as the
> pre-kdump kernel. It is using the max_pfn to determine the TCE table
> size in the non-kdump case. If there is another way to determine the
> size it used before, then I am fine making the change to use that way.
How about passing old tce table size on command line to second kernel.
Given the fact that it is specific to calgary only, we can it very
specific. Say calgary_iommu_old_tce_table_sz=<size>.
But we will then need to know the size of TCE table in first kernel. Is
this information exported to user space somewhere?
Thanks
Vivek
next prev parent reply other threads:[~2014-02-20 2:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 6:18 How could we get rid of saved_max_pfn for calgary iommu? WANG Chao
2014-02-20 0:04 ` Jon Mason
2014-02-20 2:36 ` Vivek Goyal [this message]
2014-02-21 7:47 ` WANG Chao
2014-02-21 8:18 ` Baoquan He
2014-03-05 5:36 ` WANG Chao
2014-03-06 6:47 ` Muli Ben-Yehuda
2014-03-06 6:50 ` H. Peter Anvin
2014-03-06 7:00 ` Muli Ben-Yehuda
2014-03-06 14:46 ` Jon Mason
2014-03-09 7:06 ` Muli Ben-Yehuda
2014-03-11 5:20 ` Jon Mason
2014-03-06 16:05 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220023622.GD2970@redhat.com \
--to=vgoyal@redhat.com \
--cc=chaowang@redhat.com \
--cc=discuss@x86-64.org \
--cc=hpa@zytor.com \
--cc=jdmason@kudzu.us \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox