[patch]blk-mq: remove obsolete comments

[patch]blk-mq: remove obsolete comments

[Shaohua Li]

We now have blk_mq_stop/start_queues API, delete the obsolete comments.

Signed-off-by: Shaohua Li<shli@fusionio.com>
---
 block/blk-mq.c |    5 -----
 1 file changed, 5 deletions(-)

Index: linux/block/blk-mq.c
===================================================================
--- linux.orig/block/blk-mq.c	2014-02-17 16:14:57.111662047 +0800
+++ linux/block/blk-mq.c	2014-02-19 16:22:58.114750112 +0800
@@ -598,11 +598,6 @@ static void __blk_mq_run_hw_queue(struct
 			queued++;
 			continue;
 		case BLK_MQ_RQ_QUEUE_BUSY:
-			/*
-			 * FIXME: we should have a mechanism to stop the queue
-			 * like blk_stop_queue, otherwise we will waste cpu
-			 * time
-			 */
 			list_add(&rq->queuelist, &rq_list);
 			blk_mq_requeue_request(rq);
 			break;

Re: [patch]blk-mq: remove obsolete comments

[Christoph Hellwig]

On Wed, Feb 19, 2014 at 08:22:22PM +0800, Shaohua Li wrote:
> 
> We now have blk_mq_stop/start_queues API, delete the obsolete comments.

We do have the API, but the big question is if we want to require every
driver to manually call it each time we get a busy return here.

Re: [patch]blk-mq: remove obsolete comments

[Shaohua Li]

On Wed, Feb 19, 2014 at 09:28:05AM -0800, Christoph Hellwig wrote:
> On Wed, Feb 19, 2014 at 08:22:22PM +0800, Shaohua Li wrote:
> > 
> > We now have blk_mq_stop/start_queues API, delete the obsolete comments.
> 
> We do have the API, but the big question is if we want to require every
> driver to manually call it each time we get a busy return here.

block layer can't know if driver is ready to handle request, so I'm afraid
driver should manually call it.

Thanks,
Shaohua