From: Dan Carpenter <dan.carpenter@oracle.com>
To: 黃清隆 <ching2048@areca.com.tw>
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout
Date: Fri, 21 Feb 2014 10:20:01 +0300 [thread overview]
Message-ID: <20140221072001.GF26776@mwanda> (raw)
In-Reply-To: <CAKiknE9M44XvZQSjGRSgvgUHrgfbhwj8eTNRHWJ-VO+NU=cbvA@mail.gmail.com>
On Fri, Feb 21, 2014 at 10:56:34AM +0800, 黃清隆 wrote:
> From: Ching <ching2048@areca.com.tw>
>
> Rewrite interrupt service routine to fix command timeout on controller
> too heavy loading.
>
> Singed-off-by: Ching <ching2048@areca.com.tw>
This email is still line wrapped I'm afraid. It doesn't apply.
> ---
>
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c
> b/drivers/scsi/arcmsr/arcmsr_attr.c
> --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-02-07 01:47:24.000000000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_attr.c 2014-01-10 20:28:48.000000000 +0800
> -#define ARCMSR_SCSI_INITIATOR_ID
> 255
> +#define ARCMSR_SCSI_INITIATOR_ID 255
Please do white space changes in a separate change set so that the logic
changes are easier to review.
Use "git citool". Highlight the lines with white space changes and then
right click and select "Stage lines for commit". It is a very useful
tool.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-21 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 2:56 [PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout 黃清隆
2014-02-21 7:20 ` Dan Carpenter [this message]
[not found] <CAKiknE9pf-hQOTcxbw8WnHECDJDZMHJA-TBEPeg7+q5nb+AoCA@mail.gmail.com>
2014-02-20 12:14 ` Dan Carpenter
2014-02-21 1:43 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221072001.GF26776@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ching2048@areca.com.tw \
--cc=fengguang.wu@intel.com \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox