public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: 黃清隆 <ching2048@areca.com.tw>
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
	Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH v1.3 10/11] arcmsr: Fixed coding style errors and white space change
Date: Fri, 21 Feb 2014 11:19:33 +0300	[thread overview]
Message-ID: <20140221081933.GH26776@mwanda> (raw)
In-Reply-To: <CAKiknE-FJg9y7CTMbvow277mr=H+oKkBLjDc1qDYjhHtpfBdZA@mail.gmail.com>

On Fri, Feb 21, 2014 at 12:35:58PM +0800, 黃清隆 wrote:
> From: Ching <ching2048@areca.com.tw>
> 
> Fixed coding style errors and white space change.
> 

This doesn't *just* do that.  It also has code changes.

> -static void arcmsr_hbaC_flush_cache(struct AdapterControlBlock *pACB)
> +static void
> +arcmsr_hbaC_flush_cache(struct AdapterControlBlock *pACB)
>  {
>         struct MessageUnit_C __iomem *reg = pACB->pmuC;
> -       int retry_count = 30;/* enlarge wait flush adapter cache time:
> 10 minute */
> +       int retry_count = 6;
> +
>         writel(ARCMSR_INBOUND_MESG0_FLUSH_CACHE, &reg->inbound_msgaddr0);
>         writel(ARCMSR_HBCMU_DRV2IOP_MESSAGE_CMD_DONE, &reg->inbound_doorbell);
> +       readl(&reg->inbound_doorbell);
> +       readl(&reg->inbound_msgaddr0);


We also change the printed driver string and there are other code
changes as well.

regards,
dan carpenter


      reply	other threads:[~2014-02-21  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21  4:35 [PATCH v1.3 10/11] arcmsr: Fixed coding style errors and white space change 黃清隆
2014-02-21  8:19 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140221081933.GH26776@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=ching2048@areca.com.tw \
    --cc=fengguang.wu@intel.com \
    --cc=jbottomley@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox