From: Mark Rutland <mark.rutland@arm.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"michals@xilinx.com" <michals@xilinx.com>,
Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support
Date: Fri, 21 Feb 2014 16:13:12 +0000 [thread overview]
Message-ID: <20140221161312.GA28555@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140221154103.GF31902@saruman.home>
On Fri, Feb 21, 2014 at 03:41:03PM +0000, Felipe Balbi wrote:
> Hi,
>
> On Fri, Feb 21, 2014 at 12:04:54PM +0000, Mark Rutland wrote:
> > > > +Example:
> > > > + axi-usb2-device@42e00000 {
> > > > + compatible = "xlnx,axi-usb2-device-4.00.a";
> > > > + interrupt-parent = <0x1>;
> > > > + interrupts = <0x0 0x39 0x1>;
> > > > + reg = <0x42e00000 0x10000>;
> > > > + xlnx,include-dma = <0x1>;
> > > > + };
> > > > +
> > >
> > > you need to Cc devicetree@vger.kernel.org for this.
> >
> > Cheers Filipe; thanks for adding us to Cc :)
>
> sure, but it's "Felipe" ;-)
Whoops; sorry Felipe :)
>
> > > > + /* Map the registers */
> > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > > + udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start,
> > > > + resource_size(res));
> > >
> > > use devm_ioremap_resource() instead.
> >
> > Also, res might be NULL. You should check that before dereferencing it.
>
> not needed when using devm_ioremap_resource(), see the implementation.
Ah, good to know.
Cheers,
Mark.
next prev parent reply other threads:[~2014-02-21 16:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 9:40 [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support Subbaraya Sundeep Bhatta
2014-02-20 18:23 ` Felipe Balbi
2014-02-21 6:38 ` Michal Simek
2014-02-21 16:04 ` Greg Kroah-Hartman
2014-02-21 16:04 ` Michal Simek
2014-02-21 16:12 ` SPDX-License-Identifier (was: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support) Felipe Balbi
2014-02-21 16:18 ` SPDX-License-Identifier Michal Simek
2014-02-21 16:20 ` SPDX-License-Identifier Felipe Balbi
2014-02-21 16:56 ` SPDX-License-Identifier Greg Kroah-Hartman
2014-02-21 17:26 ` SPDX-License-Identifier Michal Simek
2014-02-21 17:57 ` SPDX-License-Identifier Greg Kroah-Hartman
2014-02-21 19:01 ` SPDX-License-Identifier Theodore Ts'o
2014-02-24 10:12 ` SPDX-License-Identifier Michal Simek
2014-02-24 13:41 ` SPDX-License-Identifier Theodore Ts'o
2014-02-24 14:03 ` SPDX-License-Identifier Michal Simek
2014-02-24 14:26 ` SPDX-License-Identifier Greg Kroah-Hartman
2014-02-25 12:10 ` SPDX-License-Identifier One Thousand Gnomes
2014-02-25 12:25 ` SPDX-License-Identifier Geert Uytterhoeven
2015-02-02 15:43 ` SPDX-License-Identifier Stefan Roese
2015-02-02 16:06 ` SPDX-License-Identifier Greg Kroah-Hartman
2015-02-04 16:41 ` SPDX-License-Identifier Stefan Roese
2015-02-05 4:21 ` SPDX-License-Identifier Theodore Ts'o
2015-02-05 6:41 ` SPDX-License-Identifier Greg Kroah-Hartman
2015-02-25 21:49 ` SPDX-License-Identifier Pavel Machek
2015-02-25 22:00 ` SPDX-License-Identifier Felipe Balbi
2015-02-26 21:49 ` SPDX-License-Identifier Pavel Machek
2015-02-26 10:26 ` SPDX-License-Identifier One Thousand Gnomes
2015-02-26 13:39 ` SPDX-License-Identifier Theodore Ts'o
2015-02-26 21:53 ` SPDX-License-Identifier Pavel Machek
2015-02-05 11:49 ` SPDX-License-Identifier One Thousand Gnomes
2014-02-21 16:23 ` [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support Greg Kroah-Hartman
2014-02-21 11:27 ` Subbaraya Sundeep Bhatta
2014-02-21 15:39 ` Felipe Balbi
2014-03-10 13:36 ` sundeep subbaraya
2014-03-10 18:44 ` Felipe Balbi
2014-02-21 12:04 ` Mark Rutland
2014-02-21 13:41 ` Michal Simek
2014-02-21 13:57 ` Mark Rutland
2014-02-21 14:06 ` Michal Simek
2014-02-21 15:42 ` Felipe Balbi
2014-02-21 15:51 ` Michal Simek
2014-02-21 16:00 ` Felipe Balbi
2014-02-21 16:15 ` Arnd Bergmann
2014-02-21 15:41 ` Felipe Balbi
2014-02-21 16:13 ` Mark Rutland [this message]
2014-03-26 10:07 ` sundeep subbaraya
2014-04-15 17:18 ` Felipe Balbi
2014-04-15 17:55 ` Alan Stern
2014-04-16 4:39 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221161312.GA28555@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=sbhatta@xilinx.com \
--cc=subbaraya.sundeep.bhatta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).