From: Andy Gross <agross@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch v6 2/2] dmaengine: add Qualcomm BAM dma driver
Date: Fri, 21 Feb 2014 11:22:06 -0600 [thread overview]
Message-ID: <20140221172206.GB3102@qualcomm.com> (raw)
In-Reply-To: <20140221093352.GE7541@e106331-lin.cambridge.arm.com>
On Fri, Feb 21, 2014 at 09:33:52AM +0000, Mark Rutland wrote:
> On Fri, Feb 21, 2014 at 06:43:05AM +0000, Andy Gross wrote:
[snip]
> > + bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk");
>
> The binding document should describe the "bam_clk" string in the
> clock-names description.
>
OK.
> > + ret = of_property_read_u32(pdev->dev.of_node, "qcom,ee", &bdev->ee);
> > + if (ret) {
> > + dev_err(bdev->dev, "EE unspecified\n");
>
> It would be nice to expand EE to what it stands for, at least in the
> error but possibly the binding too.
I can expand it to execution environment. This is a trustzone thing and is
required from a security perspective.
> > +static const struct of_device_id bam_of_match[] = {
> > + { .compatible = "qcom,bam-v1.4.0", },
> > + { .compatible = "qcom,bam-v1.4.1", },
>
> What are the differences between the two?
>
> Is v1.4.1 an extension of v1.4.0?
On second look, the 1.4.1 has hardware fixes. So the software API is the same.
I thought there were some configuration changes, but that isn't the case.
> Could you have the following in DTs:
>
> compatible = "qcom,bam-v1.4.1", "qcom,bam-v1.4.0";
>
> Then you'd only need the v1.4.0 string in the driver for now.
Good point. That's easy to change.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
prev parent reply other threads:[~2014-02-21 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 6:43 [Patch v6 0/2] Add Qualcomm BAM dmaengine driver Andy Gross
2014-02-21 6:43 ` [Patch v6 1/2] dmaengine: qcom_bam_dma: Add device tree binding Andy Gross
2014-02-21 9:26 ` Mark Rutland
2014-02-21 16:30 ` Andy Gross
2014-02-21 17:36 ` Mark Rutland
2014-02-21 19:02 ` Andy Gross
2014-02-21 6:43 ` [Patch v6 2/2] dmaengine: add Qualcomm BAM dma driver Andy Gross
2014-02-21 9:33 ` Mark Rutland
2014-02-21 17:22 ` Andy Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221172206.GB3102@qualcomm.com \
--to=agross@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox