From: Tejun Heo <tj@kernel.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: Guarantee work function memory ordering
Date: Sat, 22 Feb 2014 10:41:35 -0500 [thread overview]
Message-ID: <20140222154135.GH12830@htj.dyndns.org> (raw)
In-Reply-To: <5308BCD1.3070204@hurleysoftware.com>
Hello, Peter.
On Sat, Feb 22, 2014 at 10:05:53AM -0500, Peter Hurley wrote:
> Given your concerns about the performance impact, maybe we should
> ask Fengguang to run this change through his automated test suites
> to find out what the perf delta is?
It should be fine. It's more like I just didn't like the idea of it.
Workqueue execution path isn't really light enough for an addition of
single smp_rmb() per work item execution makes any noticeable
difference. No harm in measuring perf delta but I'm highly skeptical
that there will be any difference which can be measured.
Thanks.
--
tejun
prev parent reply other threads:[~2014-02-22 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 12:11 [PATCH] workqueue: Guarantee work function memory ordering Peter Hurley
2014-02-22 14:40 ` Tejun Heo
2014-02-22 15:05 ` Peter Hurley
2014-02-22 15:41 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140222154135.GH12830@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox