* [PATCH] ASoC: wm8993: Remove unused pointer in wm8993_remove()
@ 2014-02-22 15:00 Christian Engelmayer
2014-02-25 4:34 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Christian Engelmayer @ 2014-02-22 15:00 UTC (permalink / raw)
To: Mark Brown, Wei Yongjun
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, patches, alsa-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
Commit 88b5bdfd (ASoC: wm8993: drop regulator_bulk_free of devm_ allocated
data) eliminated the last user of driver data pointer 'wm8993' in function
wm8993_remove() - Thus remove it. Detected by Coverity: CID 1186208.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Applies against branch for-next in tree
git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
---
sound/soc/codecs/wm8993.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c
index 2ee23a3..f7978b3 100644
--- a/sound/soc/codecs/wm8993.c
+++ b/sound/soc/codecs/wm8993.c
@@ -1559,8 +1559,6 @@ static int wm8993_probe(struct snd_soc_codec *codec)
static int wm8993_remove(struct snd_soc_codec *codec)
{
- struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
-
wm8993_set_bias_level(codec, SND_SOC_BIAS_OFF);
return 0;
}
--
1.8.3.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: wm8993: Remove unused pointer in wm8993_remove()
2014-02-22 15:00 [PATCH] ASoC: wm8993: Remove unused pointer in wm8993_remove() Christian Engelmayer
@ 2014-02-25 4:34 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-02-25 4:34 UTC (permalink / raw)
To: Christian Engelmayer
Cc: Wei Yongjun, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
patches, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
On Sat, Feb 22, 2014 at 04:00:16PM +0100, Christian Engelmayer wrote:
> Commit 88b5bdfd (ASoC: wm8993: drop regulator_bulk_free of devm_ allocated
> data) eliminated the last user of driver data pointer 'wm8993' in function
> wm8993_remove() - Thus remove it. Detected by Coverity: CID 1186208.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-25 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-22 15:00 [PATCH] ASoC: wm8993: Remove unused pointer in wm8993_remove() Christian Engelmayer
2014-02-25 4:34 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox