public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL v2] liblockdep fixes for v3.14
@ 2014-02-12 23:08 Sasha Levin
  2014-02-22 17:33 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2014-02-12 23:08 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Peter Zijlstra, linux-kernel@vger.kernel.org >> LKML

The following changes since commit 65370bdf881e20907e7a53abab9b8c0bc5f60a6b:

   Merge branch 'linus' into core/locking (2014-02-02 09:43:20 +0100)

are available in the git repository at:


   https://github.com/sashalevin/liblockdep.git liblockdep-fixes

for you to fetch changes up to 8a29727f2a02e3c2592ebb71c3b0216d0db8f141:

   tools/liblockdep: Use realpath for srctree and objtree (2014-02-12 16:38:02 -0500)

----------------------------------------------------------------
Ira W. Snyder (3):
       tools/liblockdep: Fix initialization code path
       tools/liblockdep: Fix include of asm/hash.h
       tools/liblockdep: Add include directory to allow tests to compile

Sasha Levin (2):
       tools/liblockdep: Mark runtests.sh as executable
       tools/liblockdep: Add a stub for new rcu_is_watching

Wang Nan (1):
       tools/liblockdep: Use realpath for srctree and objtree

  tools/lib/lockdep/Makefile             | 6 +++---
  tools/lib/lockdep/preload.c            | 2 +-
  tools/lib/lockdep/run_tests.sh         | 0
  tools/lib/lockdep/uinclude/asm/hash.h  | 6 ++++++
  tools/lib/lockdep/uinclude/linux/rcu.h | 5 +++++
  5 files changed, 15 insertions(+), 4 deletions(-)
  mode change 100644 => 100755 tools/lib/lockdep/run_tests.sh
  create mode 100644 tools/lib/lockdep/uinclude/asm/hash.h

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL v2] liblockdep fixes for v3.14
  2014-02-12 23:08 [GIT PULL v2] liblockdep fixes for v3.14 Sasha Levin
@ 2014-02-22 17:33 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2014-02-22 17:33 UTC (permalink / raw)
  To: Sasha Levin; +Cc: Peter Zijlstra, linux-kernel@vger.kernel.org >> LKML


* Sasha Levin <sasha.levin@oracle.com> wrote:

> The following changes since commit 65370bdf881e20907e7a53abab9b8c0bc5f60a6b:
> 
>   Merge branch 'linus' into core/locking (2014-02-02 09:43:20 +0100)

That's not a suitable base commit for upstream fixes (because it 
brings in tip:core/locking changes destined for v3.15!) - please use 
tip:core/urgent or one of Linus's -rc's.

Also, I found some more commit log problems.

1)

This:

    Acked-by: Sasha Levin <sasha.levin@oracle.com>
    Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Is redundant - skip the Acked-by.

2)

This:

    [sasha: Modified subject]
    Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

should in general be:

    [ Modified subject. ]
    Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Because it's obvious from the placement of the bracketed line that the 
comment is from you, no need to prefix it with 'sasha:'.

But ... more importantly, small commit log edits are typical (and 
expected) from maintainers - I do it for 99% of the patches that I 
apply, so please only add such comments if it goes outside the usual 
pattern:

   - if you've written a completely new changelog (nice from you)

   - or if you've resolved conflicts when applying the patch or 
     actually changed the code logic compared to what was submitted 
     (which should always be declared).

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-22 17:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-12 23:08 [GIT PULL v2] liblockdep fixes for v3.14 Sasha Levin
2014-02-22 17:33 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox