From: Josh Triplett <josh@joshtriplett.org>
To: Borislav Petkov <bp@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Feng Tang <feng.tang@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jacob Shin <jacob.shin@amd.com>, Jan Beulich <JBeulich@suse.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Rob Landley <rob@landley.net>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Stephane Eranian <eranian@google.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor feature names
Date: Sat, 22 Feb 2014 13:00:39 -0800 [thread overview]
Message-ID: <20140222210038.GA19867@thin> (raw)
In-Reply-To: <20140222204936.GA2534@pd.tnic>
On Sat, Feb 22, 2014 at 09:49:36PM +0100, Borislav Petkov wrote:
> On Sat, Feb 22, 2014 at 11:57:10AM -0800, Josh Triplett wrote:
> > diff --git a/arch/x86/boot/cpu.c b/arch/x86/boot/cpu.c
> > index 6ec6bb6..29207f6 100644
> > --- a/arch/x86/boot/cpu.c
> > +++ b/arch/x86/boot/cpu.c
> > @@ -16,7 +16,9 @@
> > */
> >
> > #include "boot.h"
> > +#ifdef CONFIG_X86_FEATURE_NAMES
> > #include "cpustr.h"
> > +#endif
>
> You probably could get rid of this ifdef too by moving it into cpustr.h
> after teaching arch/x86/boot/mkcpustr.c to issue it...
That would require building and running mkcpustr, which doesn't happen
when !CONFIG_X86_FEATURE_NAMES. (And it'd require adding ifdefs to
mkcpustr instead, which seems counterproductive.)
However, in exploring this, I ran into some build issues with v2 on a
clean build; I'll send out v3 shortly with fixes to those.
- Josh Triplett
next prev parent reply other threads:[~2014-02-22 21:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 19:08 [PATCH 1/2] x86: Drop support for /proc files when !CONFIG_PROC_FS Josh Triplett
2014-02-22 19:09 ` [PATCH 2/2] x86: Support compiling out human-friendly processor feature names Josh Triplett
2014-02-22 19:16 ` H. Peter Anvin
2014-02-22 19:37 ` Josh Triplett
2014-02-22 19:19 ` H. Peter Anvin
2014-02-22 19:43 ` Josh Triplett
2014-02-22 19:55 ` [PATCH v2 1/2] x86: Drop support for /proc files when !CONFIG_PROC_FS Josh Triplett
2014-02-22 21:05 ` [PATCH v3 " Josh Triplett
2014-02-22 21:06 ` [PATCH v3 2/2] x86: Support compiling out human-friendly processor feature names Josh Triplett
2014-02-22 19:57 ` [PATCH v2 " Josh Triplett
2014-02-22 20:49 ` Borislav Petkov
2014-02-22 21:00 ` Josh Triplett [this message]
2014-02-22 21:18 ` H. Peter Anvin
2014-02-22 21:36 ` Josh Triplett
2014-02-23 17:56 ` H. Peter Anvin
2014-02-23 21:32 ` Josh Triplett
2014-02-23 21:44 ` H. Peter Anvin
2014-02-23 21:55 ` Josh Triplett
2014-02-24 4:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140222210038.GA19867@thin \
--to=josh@joshtriplett.org \
--cc=JBeulich@suse.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=eranian@google.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=jussi.kivilinna@iki.fi \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rob@landley.net \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox