From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbaBVWba (ORCPT ); Sat, 22 Feb 2014 17:31:30 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35720 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbaBVWb3 (ORCPT ); Sat, 22 Feb 2014 17:31:29 -0500 X-Originating-IP: 50.43.14.201 Date: Sat, 22 Feb 2014 14:31:20 -0800 From: Josh Triplett To: Randy Dunlap Cc: Andrew Morton , Arnd Bergmann , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] bug: When !CONFIG_BUG, simplify WARN_ON_ONCE and family Message-ID: <20140222223120.GB4643@thin> References: <20140222192325.GA12587@thin> <53091CA9.3060403@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53091CA9.3060403@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 22, 2014 at 01:54:49PM -0800, Randy Dunlap wrote: > On 02/22/2014 11:23 AM, Josh Triplett wrote: > > Hi Josh, > > If you redo these patches, please make while(0) not look like a > function call, i.e., use while (0) instead. Good catch. Fixing in v2. - Josh Triplett