From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbaBWQs4 (ORCPT ); Sun, 23 Feb 2014 11:48:56 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:58427 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbaBWQsz (ORCPT ); Sun, 23 Feb 2014 11:48:55 -0500 Date: Sun, 23 Feb 2014 08:48:46 -0800 From: "Paul E. McKenney" To: josh@joshtriplett.org Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 17/55] rcutorture: Abstract torture_param() Message-ID: <20140223164846.GW4250@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20140217221231.GA8419@linux.vnet.ibm.com> <1392675179-11560-1-git-send-email-paulmck@linux.vnet.ibm.com> <1392675179-11560-17-git-send-email-paulmck@linux.vnet.ibm.com> <20140218002301.GD19929@thin> <20140218213147.GX4250@linux.vnet.ibm.com> <20140218235340.GA25804@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140218235340.GA25804@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14022316-8236-0000-0000-00000018B0A2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2014 at 03:53:40PM -0800, josh@joshtriplett.org wrote: > On Tue, Feb 18, 2014 at 01:31:47PM -0800, Paul E. McKenney wrote: > > On Mon, Feb 17, 2014 at 04:23:01PM -0800, Josh Triplett wrote: > > > On Mon, Feb 17, 2014 at 02:12:21PM -0800, Paul E. McKenney wrote: > > > > From: "Paul E. McKenney" > > > > > > > > Create a torture_param() macro and apply it to rcutorture in order to > > > > save a few lines of code. This same macro may be applied to other > > > > torture frameworks. > > > > > > > > Signed-off-by: Paul E. McKenney > > > > > > Your commit message says "torture_param", but your code says > > > "torture_parm". Let's go with the former, please; no need to creat more > > > disemvoweled abbreviations. > > > > Gd pnt, fxd s sggstd. > > Thnks! > > > > Also, this seems rather generally useful. A quick check with "git grep > > > -B2 MODULE_PARM_DESC" turns up numerous instances of the pattern. You > > > might consider adding this as a helper DECLARE_MODULE_PARAM_RO in > > > include/linux/moduleparam.h (possibly calling a generalized version that > > > takes the mode as another parameter). > > > > Added to the todo list. Another parameter is static vs. not -- I only > > had one non-static instance, which I left open-coded. > > I debated that one. You could leave out the "static" and just write > "static DECLARE_MODULE_PARAM_RO", but given that you almost always > *want* static for a module parameter... Indeed, adding a storage-class argument for the benefit of only one parameter didn't seem to make sense. Thanx, Paul