From: Josh Triplett <josh@joshtriplett.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Feng Tang <feng.tang@intel.com>,
Ingo Molnar <mingo@redhat.com>, Jacob Shin <jacob.shin@amd.com>,
Jan Beulich <JBeulich@suse.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Rob Landley <rob@landley.net>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Stephane Eranian <eranian@google.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor feature names
Date: Sun, 23 Feb 2014 13:55:52 -0800 [thread overview]
Message-ID: <20140223215552.GB14411@thin> (raw)
In-Reply-To: <530A6BB4.2070407@zytor.com>
On Sun, Feb 23, 2014 at 01:44:20PM -0800, H. Peter Anvin wrote:
> On 02/23/2014 01:32 PM, Josh Triplett wrote:
> >
> > Because, in order to un-break the build, v3 wraps an ifdef around that
> > dependency, to prevent building cpustr.h. Otherwise, the rule for
> > cpustr.h tries and fails to build mkcpustr.
> >
>
> Why did it fail to build mkcpustr? It would seem that mkcpustr is or at
> least ought to be completely agnostic to any of these options.
>
> The extra build machinery here seems completely pointless.
>
> I agree that the #ifdef isn't a big deal, but all this extra machinery
> really indicates something is odd.
>
> Oh, and of course, looking at the v2 patchset, the problem is the ifdef
> around the mkcapflags shell script which really shouldn't be necessary.
> We may have to add a rule to force capflags.c to be built even if
> capflags.o is not requested, but that is fine.
>
> That will cut down on the Makefile hacks considerably, and will avoid
> this problem completely.
Why have the build system waste time building several things that won't
be used? It seems like the Makefiles are exactly where we *should* have
the ifdef machinery, rather than in source. I'd happily add another
ifdef in the Makefile rule that builds cpustr.h, to generate a stub
cpustr.h header, and then remove one more ifdef in the source.
- Josh Triplett
next prev parent reply other threads:[~2014-02-23 21:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 19:08 [PATCH 1/2] x86: Drop support for /proc files when !CONFIG_PROC_FS Josh Triplett
2014-02-22 19:09 ` [PATCH 2/2] x86: Support compiling out human-friendly processor feature names Josh Triplett
2014-02-22 19:16 ` H. Peter Anvin
2014-02-22 19:37 ` Josh Triplett
2014-02-22 19:19 ` H. Peter Anvin
2014-02-22 19:43 ` Josh Triplett
2014-02-22 19:55 ` [PATCH v2 1/2] x86: Drop support for /proc files when !CONFIG_PROC_FS Josh Triplett
2014-02-22 21:05 ` [PATCH v3 " Josh Triplett
2014-02-22 21:06 ` [PATCH v3 2/2] x86: Support compiling out human-friendly processor feature names Josh Triplett
2014-02-22 19:57 ` [PATCH v2 " Josh Triplett
2014-02-22 20:49 ` Borislav Petkov
2014-02-22 21:00 ` Josh Triplett
2014-02-22 21:18 ` H. Peter Anvin
2014-02-22 21:36 ` Josh Triplett
2014-02-23 17:56 ` H. Peter Anvin
2014-02-23 21:32 ` Josh Triplett
2014-02-23 21:44 ` H. Peter Anvin
2014-02-23 21:55 ` Josh Triplett [this message]
2014-02-24 4:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223215552.GB14411@thin \
--to=josh@joshtriplett.org \
--cc=JBeulich@suse.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=eranian@google.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=jussi.kivilinna@iki.fi \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rob@landley.net \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox