* [PATCH v2] staging: ced401: fix double unlock bug
@ 2014-02-24 10:23 Daeseok Youn
2014-02-24 10:31 ` Dan Carpenter
2014-02-25 0:43 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Daeseok Youn @ 2014-02-24 10:23 UTC (permalink / raw)
To: gregkh; +Cc: ufimtseva, paul.gortmaker, devel, linux-kernel, dan.carpenter
After spin_lock() is called, all of if-else conditions in this brace
should reach the end of else and spin_unlock() must be called.
So It doesn't need to call spin_unlock() without a return statement
for handling an error.
Also sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/ced1401/usb1401.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c
index efc310c..8195eb9 100644
--- a/drivers/staging/ced1401/usb1401.c
+++ b/drivers/staging/ced1401/usb1401.c
@@ -1053,7 +1053,6 @@ static int Handle1401Esc(DEVICE_EXTENSION *pdx, char *pCh,
/* This can never happen, really */
dev_err(&pdx->interface->dev,
"ERROR: DMA setup while transfer still waiting");
- spin_unlock(&pdx->stagedLock);
} else {
if ((wTransType == TM_EXTTOHOST)
|| (wTransType == TM_EXTTO1401)) {
--
1.7.9.5
---
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: ced401: fix double unlock bug
2014-02-24 10:23 [PATCH v2] staging: ced401: fix double unlock bug Daeseok Youn
@ 2014-02-24 10:31 ` Dan Carpenter
2014-02-25 0:43 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-02-24 10:31 UTC (permalink / raw)
To: Daeseok Youn; +Cc: gregkh, ufimtseva, paul.gortmaker, devel, linux-kernel
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>
> After spin_lock() is called, all of if-else conditions in this brace
> should reach the end of else and spin_unlock() must be called.
> So It doesn't need to call spin_unlock() without a return statement
> for handling an error.
>
> Also sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
> context imbalance in 'Handle1401Esc' - unexpected unlock
>
Thank you.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: ced401: fix double unlock bug
2014-02-24 10:23 [PATCH v2] staging: ced401: fix double unlock bug Daeseok Youn
2014-02-24 10:31 ` Dan Carpenter
@ 2014-02-25 0:43 ` Greg KH
2014-02-25 1:00 ` DaeSeok Youn
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2014-02-25 0:43 UTC (permalink / raw)
To: Daeseok Youn
Cc: devel, paul.gortmaker, dan.carpenter, linux-kernel, ufimtseva
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>
> After spin_lock() is called, all of if-else conditions in this brace
> should reach the end of else and spin_unlock() must be called.
> So It doesn't need to call spin_unlock() without a return statement
> for handling an error.
>
> Also sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
> context imbalance in 'Handle1401Esc' - unexpected unlock
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
This patch doesn't apply to my tree, can you please redo it against
linux-next and resend it so that I can apply it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] staging: ced401: fix double unlock bug
2014-02-25 0:43 ` Greg KH
@ 2014-02-25 1:00 ` DaeSeok Youn
0 siblings, 0 replies; 4+ messages in thread
From: DaeSeok Youn @ 2014-02-25 1:00 UTC (permalink / raw)
To: Greg KH; +Cc: devel, paul.gortmaker, Dan Carpenter, linux-kernel,
Elena Ufimtseva
Ok.
I will make a patch based on linux-next branch and send it again.
Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>>
>> After spin_lock() is called, all of if-else conditions in this brace
>> should reach the end of else and spin_unlock() must be called.
>> So It doesn't need to call spin_unlock() without a return statement
>> for handling an error.
>>
>> Also sparse says:
>> drivers/staging/ced1401/usb1401.c:1080:28: warning:
>> context imbalance in 'Handle1401Esc' - unexpected unlock
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>
> This patch doesn't apply to my tree, can you please redo it against
> linux-next and resend it so that I can apply it?
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-25 1:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-24 10:23 [PATCH v2] staging: ced401: fix double unlock bug Daeseok Youn
2014-02-24 10:31 ` Dan Carpenter
2014-02-25 0:43 ` Greg KH
2014-02-25 1:00 ` DaeSeok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).