From: Greg KH <gregkh@linuxfoundation.org>
To: axel.rasmussen1@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: fix checkpatch.pl issues
Date: Mon, 24 Feb 2014 15:47:38 -0800 [thread overview]
Message-ID: <20140224234738.GA22241@kroah.com> (raw)
In-Reply-To: <3159008.9WafSrHc87@celine>
On Thu, Feb 20, 2014 at 01:05:31AM -0700, axel.rasmussen1@gmail.com wrote:
> From: Axel Rasmussen <axel.rasmussen1@gmail.com>
> Date: Mon, 17 Feb 2014 23:50:05 -0700
> Subject: [PATCH] staging: rtl8187se: fix checkpatch.pl issues
Please just use 'git send-email' so I don't have to hand-edit the patch
and strip this out :(
>
> Reformatted many lines which were too long, replaced various printk
> calls with appropriate netdev_* calls, and fixed some spelling errors.
You did multiple things here to this patch, which should be a big hint
that you need to break it up into smaller pieces, each one doing just
one thing. Please do so, otherwise as it is, this patch is way too big
to review.
thanks,
greg k-h
prev parent reply other threads:[~2014-02-24 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 8:05 [PATCH] staging: rtl8187se: fix checkpatch.pl issues axel.rasmussen1
2014-02-24 23:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224234738.GA22241@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axel.rasmussen1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox