From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: "Austin, Brian" <Brian.Austin@cirrus.com>,
"Handrigan, Paul" <Paul.Handrigan@cirrus.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rob@landley.net" <rob@landley.net>,
Liam Girdwood <lgirdwood@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: cs42888: Add codec driver support
Date: Tue, 25 Feb 2014 09:00:27 +0900 [thread overview]
Message-ID: <20140225000027.GI25940@sirena.org.uk> (raw)
In-Reply-To: <20140224160648.GC6132@MrMyself>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Tue, Feb 25, 2014 at 12:06:49AM +0800, Nicolin Chen wrote:
> On Mon, Feb 24, 2014 at 03:52:24PM +0000, Austin, Brian wrote:
> Wait...Regarding this clock part, I just forgot the reason I put the code:
> 385 cs42888->clk = devm_clk_get(&i2c->dev, "mclk");
> 386 if (IS_ERR(cs42888->clk))
> 387 dev_warn(&i2c->dev, "failed to get the clock: %ld\n",
> 388 PTR_ERR(cs42888->clk));
> was because the MCLK might be provided from SoC (DAI master) so it could
> be totally controlled by CPU DAI driver, ESAI for example has its own
> dividers to derive the HCKT clock (MCLK for Tx) from ahb clock in SoC
> clock tree, in which case we might not easily pass a valid clock phandle
> via DT. (RFC to this thought.)
We should be getting those clocks visible in the clock API rather than
doing this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-25 0:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 6:55 [PATCH] ASoC: cs42888: Add codec driver support Nicolin Chen
2014-02-24 11:30 ` Mark Brown
2014-02-24 15:47 ` Nicolin Chen
2014-02-24 15:52 ` Austin, Brian
2014-02-24 15:47 ` Nicolin Chen
2014-02-24 16:06 ` Nicolin Chen
2014-02-24 16:32 ` Austin, Brian
2014-02-25 2:32 ` Nicolin Chen
2014-02-25 0:00 ` Mark Brown [this message]
2014-02-25 2:38 ` Nicolin Chen
2014-02-25 3:09 ` Mark Brown
2014-02-25 3:13 ` Nicolin Chen
2014-02-25 3:39 ` Mark Brown
2014-02-25 3:46 ` Nicolin Chen
2014-02-25 3:52 ` Mark Brown
2014-02-25 3:54 ` Nicolin Chen
2014-02-25 3:54 ` [alsa-devel] " Fabio Estevam
2014-02-25 3:55 ` Nicolin Chen
2014-02-24 17:54 ` Lars-Peter Clausen
2014-02-25 2:39 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225000027.GI25940@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Brian.Austin@cirrus.com \
--cc=Guangyu.Chen@freescale.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox