From: Peter Chen <peter.chen@freescale.com>
To: Neil Zhang <zhangwm@marvell.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0
Date: Tue, 25 Feb 2014 09:18:40 +0800 [thread overview]
Message-ID: <20140225011839.GD7540@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <1393228996-14787-3-git-send-email-zhangwm@marvell.com>
On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote:
> Hardware zlt will try to send the zero length packet automatically
> when the data transferd is multiple times of max packet, this will
> cause issues on Windows.
> So let's disable HW zlt by default.
Would you have description that what kinds of issue on Windows
if zlt is is selected?
Peter
>
> Signed-off-by: Neil Zhang <zhangwm@marvell.com>
> ---
> drivers/usb/gadget/mv_udc_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
> index ebc0dfd..657ac5c 100644
> --- a/drivers/usb/gadget/mv_udc_core.c
> +++ b/drivers/usb/gadget/mv_udc_core.c
> @@ -89,7 +89,7 @@ static void ep0_reset(struct mv_udc *udc)
> /* configure ep0 endpoint capabilities in dQH */
> ep->dqh->max_packet_length =
> (EP0_MAX_PKT_SIZE << EP_QUEUE_HEAD_MAX_PKT_LEN_POS)
> - | EP_QUEUE_HEAD_IOS;
> + | EP_QUEUE_HEAD_IOS | EP_QUEUE_HEAD_ZLT_SEL;
>
> ep->dqh->next_dtd_ptr = EP_QUEUE_HEAD_NEXT_TERMINATE;
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2014-02-25 2:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 8:03 [PATCH 0/6] bug fix for mv_udc_core.c Neil Zhang
2014-02-24 8:03 ` [PATCH 1/6] usb: gadget: mv_udc: remove redundant pull up in udc_start Neil Zhang
2014-02-24 8:03 ` [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0 Neil Zhang
2014-02-25 1:18 ` Peter Chen [this message]
2014-02-25 4:13 ` Neil Zhang
2014-02-25 5:15 ` Peter Chen
2014-02-25 7:11 ` Neil Zhang
2014-02-25 7:46 ` Peter Chen
2014-02-25 18:12 ` Felipe Balbi
2014-02-26 1:48 ` Neil Zhang
2014-02-26 2:36 ` Peter Chen
2014-02-26 15:20 ` Felipe Balbi
2014-02-26 15:23 ` Felipe Balbi
2014-02-27 3:30 ` Peter Chen
2014-02-27 16:52 ` Felipe Balbi
2014-02-27 18:05 ` Fabio Estevam
2014-02-27 19:04 ` Felipe Balbi
2014-02-26 15:19 ` Felipe Balbi
2014-02-27 9:12 ` Neil Zhang
2014-02-24 8:03 ` [PATCH 3/6] usb: gadget: mv_udc: clear corresponding interrupt when flush fifo Neil Zhang
2014-02-25 1:59 ` Peter Chen
2014-02-25 7:26 ` Neil Zhang
2014-02-24 8:03 ` [PATCH 4/6] usb: gadget: mv_udc: check endpoint before queue dtd Neil Zhang
2014-02-24 8:03 ` [PATCH 5/6] USB: gadget: mv_udc: workaroud for missing dTD Neil Zhang
2014-02-25 4:19 ` Peter Chen
2014-02-25 7:16 ` Neil Zhang
2014-02-25 7:22 ` Peter Chen
2014-02-24 8:03 ` [PATCH 6/6] USB: gadget: mv_udc: fix corner case for missiong dTD Neil Zhang
2014-02-24 10:31 ` [PATCH 0/6] bug fix for mv_udc_core.c Matthieu CASTET
2014-02-24 12:42 ` Neil Zhang
2014-02-25 4:17 ` Peter Chen
2014-02-25 7:18 ` Neil Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225011839.GD7540@shlinux1.ap.freescale.net \
--to=peter.chen@freescale.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhangwm@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).