From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbaBYKC1 (ORCPT ); Tue, 25 Feb 2014 05:02:27 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:62549 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbaBYKCX (ORCPT ); Tue, 25 Feb 2014 05:02:23 -0500 Date: Tue, 25 Feb 2014 10:02:16 +0000 From: Lee Jones To: Charles Keepax Cc: broonie@kernel.org, gregkh@linuxfoundation.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 3/3] mfd: arizona: Use new regmap features for manual register patch Message-ID: <20140225100216.GA13246@lee--X1> References: <1393011432-28909-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1393011432-28909-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20140224161042.GF15847@lee--X1> <20140225093723.GE5438@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140225093723.GE5438@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > On the wm5102 the register patches are applied manually, rather than by > > > the regmap core. This application is wrapped in calls to > > > regcache_cache_bypass. However, this is dangerous as other threads may > > > be accessing the hardware at the same time as the pm_runtime operations > > > and if they do so during the period whilst cache_bypass is enabled those > > > writes will miss the cache when they shouldn't. > > > > > > Apply the register patch using the new regmap_apply_patch function to > > > avoid this problem. Also remove the call to regcache_cache_bypass from > > > the hardware patch application as it is unneeded there and creates a > > > similar window for writes to miss the cache. > > > > > > Signed-off-by: Charles Keepax > > > --- > > > drivers/mfd/arizona-core.c | 4 ---- > > > drivers/mfd/wm5102-tables.c | 19 ++----------------- > > > 2 files changed, 2 insertions(+), 21 deletions(-) > > > > Applied, thanks. > > Apologies this patch depends on the previous patch I am still > working Mark's comments for. So this can't really be applied at > the moment. It's a good idea to let us know about any inter-patch dependencies, so we may act accordingly. I'll remove this from my -next branch for now. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog