Re: [PATCH V1 2/3] MFD: da9052: Add new DA9053 BC chip variant

[Lee Jones <lee.jones@linaro.org>]

> > > Add support for a new BC variant of the DA9053 PMIC.
> > > There is one difference between it and the AA, BA and BB.
> > > This patch also corrects a typing mistake in one of the BA name
> > > strings that was incorrectly typed as "ab".
> > > Signed-off-by: Anthony Olech <anthony.olech.opensource@diasemi.com>
> > > ---
> > >
> > > This patch is relative to linux-next repository tag next-20140219
> > 
> > That's not generally a good idea.
> > Please use a Mainline version (inc. -rcs).
> 
> Hi Lee,
> 
> thanks for applying the patch.
> 
> I can rebase against any tagged version in a public git repository, but in the past
> I was advised to use linux-next instead of the mainline. At this moment in time
> the latest tag in git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> is 'v3.14-rc4'
> 
> Are you recommending that tag as the one to rebase (and test of course) against?

I am. The trouble with basing your patches against -next is that it's
not stable, in that it is rebuilt every day. If your patches are
dependant on commits which haven't reached Mainline yet, then you
should rebase on the subsystem tree which they are contained in. All
patches in -next should be based on an -rc or a released kernel version.

> > > This patch depends on patch number 1 of this patch series being
> > > applied first or it will not compile.
> > >
> > >  drivers/mfd/da9052-i2c.c |    5 ++++-
> > >  drivers/mfd/da9052-spi.c |    1 +
> > >  2 files changed, 5 insertions(+), 1 deletion(-)
> > 
> > Applied, thanks.
> > 

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog