From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Anton Vorontsov <anton@enomsg.org>,
Alexey Perevalov <a.perevalov@samsung.com>,
kyungmin.park@samsung.com, cw00.choi@samsung.com
Subject: Re: [RFC patch 1/5] hrtimer: Always check for HRTIMER_MODE_REL
Date: Tue, 25 Feb 2014 12:56:07 +0100 [thread overview]
Message-ID: <20140225115607.GQ9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140221174639.461201411@linutronix.de>
On Fri, Feb 21, 2014 at 05:56:15PM -0000, Thomas Gleixner wrote:
> We have not just HRTIMER_MODE_REL and HRTIMER_MODE_ABS, so a direct
> check for mode == HRTIMER_MODE_ABS is not sufficient.
>
> Always check for the HRTIMER_MODE_REL bit.
This seems to come from having changed hrtimer_mode from a value field
to a bit field with the addition of PINNED.
But yeah; this certainly fixes these two sites. Ideally we'd to
something better to avoid making the same mistake again later. But the
only thing I can come up with is lots of work.
Acked-by: Peter Zijlstra <peterz@infradead.org>
next prev parent reply other threads:[~2014-02-25 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 17:56 [RFC patch 0/5] hrtimers: Add deferrable mode Thomas Gleixner
2014-02-21 17:56 ` [RFC patch 1/5] hrtimer: Always check for HRTIMER_MODE_REL Thomas Gleixner
2014-02-25 11:56 ` Peter Zijlstra [this message]
2014-02-21 17:56 ` [RFC patch 2/5] hrtimer: Make use of the active bases bitfield Thomas Gleixner
2014-02-25 12:01 ` Peter Zijlstra
2014-02-21 17:56 ` [RFC patch 3/5] hrtimer: Add support for deferrable hrtimers Thomas Gleixner
2014-02-21 17:56 ` [RFC patch 4/5] posix-timers: Expose deferrable mode to user space Thomas Gleixner
2014-02-21 17:56 ` [RFC patch 5/5] timerfd: " Thomas Gleixner
2014-02-25 8:36 ` Richard Cochran
2014-02-26 3:02 ` [RFC patch 0/5] hrtimers: Add deferrable mode Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225115607.GQ9987@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.perevalov@samsung.com \
--cc=anton@enomsg.org \
--cc=cw00.choi@samsung.com \
--cc=john.stultz@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox