From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbaBZJaL (ORCPT ); Wed, 26 Feb 2014 04:30:11 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:33698 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751787AbaBZJaJ (ORCPT ); Wed, 26 Feb 2014 04:30:09 -0500 Date: Wed, 26 Feb 2014 12:29:54 +0300 From: Dan Carpenter To: Joe Perches Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Subject: Re: WARNING: Unnecessary parentheses - maybe == should be = ? Message-ID: <20140226092954.GW26776@mwanda> References: <20140210092710.GA10899@elgon.mountain> <1392052786.2507.20.camel@joe-AO722> <20140210202411.GD26776@mwanda> <1392069596.2507.23.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392069596.2507.23.camel@joe-AO722> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 01:59:56PM -0800, Joe Perches wrote: > On Mon, 2014-02-10 at 23:24 +0300, Dan Carpenter wrote: > > On Mon, Feb 10, 2014 at 09:19:46AM -0800, Joe Perches wrote: > > > On Mon, 2014-02-10 at 12:27 +0300, Dan Carpenter wrote: > > > > We do not want to encourage a million > > > > first patch submitters to start introducing = vs == bugs. > > > Definitely true and I didn't think of that. > > So long as we can re-phrase it then I don't have a problem with the > > warning. > > Do you have a suggested phrasing? > Unnecessary parentheses - this is C not LISP dummy. regards, dan carpenter