public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [RFA][PATCH 0/4] tracing: Request for acks on fixing tracepoint code
Date: Wed, 26 Feb 2014 14:01:40 -0500	[thread overview]
Message-ID: <20140226190140.590029589@goodmis.org> (raw)

[ Request for Acks ]

Due to module tainting, we have tracepoints that silently do not work.
That will be solved another way. But the trace event infrastructure should
not be created for tainted modules. That is, the debugfs files should
not exist for them.

By moving the tracepoint module taint test into tracepoint.h, we can
reuse that same test when creating the module tracepoint events.

Note, I had to remove the tracepoint.h include from module.h as there
was nothing in module.h that required tracepoint.h, but this broke
a couple of event files (migrate.h and writeback.h) because they did
not include tracepoint.h, and were just lucky that it was included
by module.h.

Steven Rostedt (Red Hat) (4):
      tracing: Fix event header writeback.h to include tracepoint.h
      tracing: Fix event header migrate.h to include tracepoint.h
      tracing/module: Remove include of tracepoint.h from module.h
      tracing: Do not add event files for modules that fail tracepoints

----
 include/linux/module.h           |  1 -
 include/linux/tracepoint.h       |  7 +++++++
 include/trace/events/migrate.h   |  2 ++
 include/trace/events/writeback.h |  1 +
 kernel/trace/trace_events.c      |  4 ++++
 kernel/tracepoint.c              |  2 +-
 6 files changed, 23 insertions(+), 21 deletions(-)

             reply	other threads:[~2014-02-26 19:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 19:01 Steven Rostedt [this message]
2014-02-26 19:01 ` [RFA][PATCH 1/4] tracing: Fix event header writeback.h to include tracepoint.h Steven Rostedt
2014-02-26 19:01 ` [RFA][PATCH 2/4] tracing: Fix event header migrate.h " Steven Rostedt
2014-02-28 11:22   ` Mel Gorman
2014-02-26 19:01 ` [RFA][PATCH 3/4] tracing/module: Remove include of tracepoint.h from module.h Steven Rostedt
2014-02-27  3:13   ` Steven Rostedt
2014-03-17  2:34     ` Rusty Russell
2014-03-17  6:42       ` Steven Rostedt
2014-02-26 19:01 ` [RFA][PATCH 4/4] tracing: Do not add event files for modules that fail tracepoints Steven Rostedt
2014-02-26 21:36 ` [RFA][PATCH 0/4] tracing: Request for acks on fixing tracepoint code Mathieu Desnoyers
2014-02-27  1:38   ` Steven Rostedt
2014-02-27  2:21     ` Mathieu Desnoyers
2014-02-27  2:43       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226190140.590029589@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox