From: Josh Cartwright <joshc@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs
Date: Wed, 26 Feb 2014 20:31:15 -0600 [thread overview]
Message-ID: <20140227023115.GA7308@joshc.qualcomm.com> (raw)
In-Reply-To: <530E8A17.8060603@codeaurora.org>
On Wed, Feb 26, 2014 at 04:43:03PM -0800, Stephen Boyd wrote:
> On 02/26/14 16:30, Josh Cartwright wrote:
> > On Wed, Feb 26, 2014 at 04:20:03PM -0800, Stephen Boyd wrote:
> >> On 02/26/14 16:13, Josh Cartwright wrote:
> >>> On Wed, Feb 26, 2014 at 04:05:40PM -0800, Stephen Boyd wrote:
> >>>> On 02/26/14 15:59, Josh Cartwright wrote:
> >>> However, I think it needs to be made clear that your if "Modernize pm8921
> >>> with irqdomains, regmap, DT" lands before this patchset, this will start
> >>> breaking randconfig builds. It isn't clear to me how this dependency
> >>> should be handled.
> >>>
> >> Hmm? If pm8921 lands before this what build breakage is there? The
> >> pm8xxx_read/write APIs are still exposed.
> > Well, with the pm8921 patchset in place, the keypad driver becomes
> > selectable, which, when built leads to the error below. But AFAICT,
> > this isn't even addressed in this patchset?!
> >
> > drivers/input/keyboard/pmic8xxx-keypad.c:24:35: fatal error: linux/mfd/pm8xxx/gpio.h: No such file or directory
> > #include <linux/mfd/pm8xxx/gpio.h>
> > ^
> >
> > So, I'm confused...maybe the pm8921 cleanup patchset should be marking
> > the keypad driver BROKEN?
> >
>
> Ah, yes probably. I have a patch locally that rips out the gpio stuff
> because this driver has been uncompilable since it was introduced. I may
> as well send that along with this series so that people can actually
> compile this driver. Or like you say, send it along with the removal of
> the BROKEN in pm8921 Kconfig.
Yeah, I think it should probably land before MFD_PM8XXX's BROKEN
removal, just to eliminate randconfig breakage noise. I double-checked,
and it looks like at least the other drivers that depend on MFD_PM8XXX
still build (with a couple sparse warnings).
Also.....it's driving me nuts that some of the pm8xxx drivers use
"pm8xxx-foo", and others use "pmic8xxx-foo"...
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-27 2:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 19:05 [PATCH v3 0/9] Use regmap+devm+DT in pm8xxx input drivers Stephen Boyd
2014-02-26 19:05 ` [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs Stephen Boyd
2014-02-26 23:59 ` Josh Cartwright
2014-02-27 0:05 ` Stephen Boyd
2014-02-27 0:13 ` Josh Cartwright
2014-02-27 0:20 ` Stephen Boyd
2014-02-27 0:30 ` Josh Cartwright
2014-02-27 0:43 ` Stephen Boyd
2014-02-27 2:31 ` Josh Cartwright [this message]
2014-02-26 19:05 ` [PATCH v3 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs Stephen Boyd
2014-02-27 0:09 ` Josh Cartwright
2014-02-27 0:20 ` Stephen Boyd
2014-02-26 19:05 ` [PATCH v3 3/9] Input: pmic8xxx-keypad - Migrate to regmap APIs Stephen Boyd
2014-02-26 19:05 ` [PATCH v3 4/9] Input: pmic8xxx-pwrkey - Migrate to DT Stephen Boyd
2014-02-26 19:05 ` [PATCH v3 5/9] Input: pm8xxx-vibrator - Add DT match table Stephen Boyd
2014-02-26 19:05 ` [PATCH v3 6/9] Input: pmic8xxx-keypad - Migrate to DT Stephen Boyd
2014-02-26 19:06 ` [PATCH v3 7/9] devicetree: bindings: Document PM8921/8058 keypads Stephen Boyd
2014-02-26 19:06 ` [PATCH v3 8/9] devicetree: bindings: Document PM8921/8058 power keys Stephen Boyd
2014-02-26 19:06 ` [PATCH v3 9/9] devicetree: bindings: Document PM8921/8058 vibrators Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227023115.GA7308@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox