* [RFC][PATCH] staging: Fix build issues with new binder API
@ 2014-02-26 22:29 John Stultz
2014-02-27 3:34 ` Greg KH
[not found] ` <530E6B56.8060405@linaro.org>
0 siblings, 2 replies; 6+ messages in thread
From: John Stultz @ 2014-02-26 22:29 UTC (permalink / raw)
To: LKML
Cc: John Stultz, Greg KH, Colin Cross, Arve Hjønnevåg,
Serban Constantinescu, Android Kernel Team
The new 64bit binder API causes build issues on 32bit ARM
due to the lack of 64bit __get_user_asm_* implementation.
Until that implementation is done, remove the choice for
32bit ARM, automatically enabling the old 32bit binder
protocol.
This can be reverted once a 64bit __get_user_asm_*
implementation is merged.
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Colin Cross <ccross@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Android Kernel Team <kernel-team@android.com>
Reported-by: Arnd Bergmann <arnd.bergmann@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/staging/android/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 1c779ef..ab28d2b 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -21,7 +21,7 @@ config ANDROID_BINDER_IPC
between said processes.
config ANDROID_BINDER_IPC_32BIT
- bool "Use old (Android 4.4 and earlier) 32-bit binder API"
+ bool
depends on !64BIT && ANDROID_BINDER_IPC
default y
---help---
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RFC][PATCH] staging: Fix build issues with new binder API
2014-02-26 22:29 [RFC][PATCH] staging: Fix build issues with new binder API John Stultz
@ 2014-02-27 3:34 ` Greg KH
2014-02-27 19:04 ` John Stultz
[not found] ` <530E6B56.8060405@linaro.org>
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-02-27 3:34 UTC (permalink / raw)
To: John Stultz
Cc: LKML, Colin Cross, Arve Hjønnevåg,
Serban Constantinescu, Android Kernel Team
On Wed, Feb 26, 2014 at 02:29:07PM -0800, John Stultz wrote:
> The new 64bit binder API causes build issues on 32bit ARM
> due to the lack of 64bit __get_user_asm_* implementation.
So no one ever tested this out on ARM? Really, that seems odd...
Anyway, if you want this to always be on, that's fine with me, your
choice :)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC][PATCH] staging: Fix build issues with new binder API
2014-02-27 3:34 ` Greg KH
@ 2014-02-27 19:04 ` John Stultz
2014-02-27 19:12 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: John Stultz @ 2014-02-27 19:04 UTC (permalink / raw)
To: Greg KH
Cc: LKML, Colin Cross, Arve Hjønnevåg,
Serban Constantinescu, Android Kernel Team, Arnd Bergmann
On 02/26/2014 07:34 PM, Greg KH wrote:
> On Wed, Feb 26, 2014 at 02:29:07PM -0800, John Stultz wrote:
>> The new 64bit binder API causes build issues on 32bit ARM
>> due to the lack of 64bit __get_user_asm_* implementation.
> So no one ever tested this out on ARM? Really, that seems odd...
Its my bad, I was focused on the 32bit legacy compatibility code in my
testing because the userspace I have only works with that.
Arve actually warned about this in one of his mails, but I mistakenly
thought it was an issue w/ 3.10 and earlier kernels and had since been
addressed.
> Anyway, if you want this to always be on, that's fine with me, your
> choice :)
I think its the best option for now, but wanted to send it out for
comment to see if anyone objected.
I'm about to head for a conference so I'll be offline until around
Monday. While at the conference I'm going to be working with folks to
see if we can't get the real solution (a __get_user_asm_64
implementation) sorted. But if there are no objections, it might be
best to queue this for staging-next so folks don't hit the issue in the
meantime.
thanks
-john
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC][PATCH] staging: Fix build issues with new binder API
2014-02-27 19:04 ` John Stultz
@ 2014-02-27 19:12 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-02-27 19:12 UTC (permalink / raw)
To: John Stultz
Cc: LKML, Colin Cross, Arve Hjønnevåg,
Serban Constantinescu, Android Kernel Team, Arnd Bergmann
On Thu, Feb 27, 2014 at 11:04:01AM -0800, John Stultz wrote:
> On 02/26/2014 07:34 PM, Greg KH wrote:
> > On Wed, Feb 26, 2014 at 02:29:07PM -0800, John Stultz wrote:
> >> The new 64bit binder API causes build issues on 32bit ARM
> >> due to the lack of 64bit __get_user_asm_* implementation.
> > So no one ever tested this out on ARM? Really, that seems odd...
>
> Its my bad, I was focused on the 32bit legacy compatibility code in my
> testing because the userspace I have only works with that.
>
> Arve actually warned about this in one of his mails, but I mistakenly
> thought it was an issue w/ 3.10 and earlier kernels and had since been
> addressed.
>
>
> > Anyway, if you want this to always be on, that's fine with me, your
> > choice :)
>
> I think its the best option for now, but wanted to send it out for
> comment to see if anyone objected.
>
> I'm about to head for a conference so I'll be offline until around
> Monday. While at the conference I'm going to be working with folks to
> see if we can't get the real solution (a __get_user_asm_64
> implementation) sorted. But if there are no objections, it might be
> best to queue this for staging-next so folks don't hit the issue in the
> meantime.
Yes, the "real" solution would be best, but I'll queue this up for now,
thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <530E6B56.8060405@linaro.org>]
* Re: Fwd: [RFC][PATCH] staging: Fix build issues with new binder API
[not found] ` <530E6B56.8060405@linaro.org>
@ 2014-02-27 19:15 ` Arnd Bergmann
2014-02-27 19:20 ` John Stultz
0 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2014-02-27 19:15 UTC (permalink / raw)
To: John Stultz
Cc: Greg KH, Colin Cross, Arve Hjønnevåg,
Serban Constantinescu, Android Kernel Team, LKML
On Wednesday 26 February 2014, John Stultz wrote:
> The new 64bit binder API causes build issues on 32bit ARM
> due to the lack of 64bit __get_user_asm_* implementation.
It is impossible to implement this. Many have tried before.
> Until that implementation is done, remove the choice for
> 32bit ARM, automatically enabling the old 32bit binder
> protocol.
>
> This can be reverted once a 64bit __get_user_asm_*
> implementation is merged.
I think the best solution is to use __copy_from_user for
the 64-bit access. You can wrap it in a helper function
if you want to speed up the native-word-size case.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Fwd: [RFC][PATCH] staging: Fix build issues with new binder API
2014-02-27 19:15 ` Fwd: " Arnd Bergmann
@ 2014-02-27 19:20 ` John Stultz
0 siblings, 0 replies; 6+ messages in thread
From: John Stultz @ 2014-02-27 19:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg KH, Colin Cross, Arve Hjønnevåg,
Serban Constantinescu, Android Kernel Team, LKML
On 02/27/2014 11:15 AM, Arnd Bergmann wrote:
> On Wednesday 26 February 2014, John Stultz wrote:
>> The new 64bit binder API causes build issues on 32bit ARM
>> due to the lack of 64bit __get_user_asm_* implementation.
> It is impossible to implement this. Many have tried before.
>
>> Until that implementation is done, remove the choice for
>> 32bit ARM, automatically enabling the old 32bit binder
>> protocol.
>>
>> This can be reverted once a 64bit __get_user_asm_*
>> implementation is merged.
> I think the best solution is to use __copy_from_user for
> the 64-bit access. You can wrap it in a helper function
> if you want to speed up the native-word-size case.
Ah. Thanks for the context and the tip. Will try to get an appropriate
solution there then.
thanks
-john
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-27 19:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-26 22:29 [RFC][PATCH] staging: Fix build issues with new binder API John Stultz
2014-02-27 3:34 ` Greg KH
2014-02-27 19:04 ` John Stultz
2014-02-27 19:12 ` Greg KH
[not found] ` <530E6B56.8060405@linaro.org>
2014-02-27 19:15 ` Fwd: " Arnd Bergmann
2014-02-27 19:20 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox