From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbaB0QjQ (ORCPT ); Thu, 27 Feb 2014 11:39:16 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36015 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaB0QjO (ORCPT ); Thu, 27 Feb 2014 11:39:14 -0500 Date: Thu, 27 Feb 2014 08:40:51 -0800 From: Greg KH To: Reza Snowdon Cc: devel@driverdev.osuosl.org, speakup@braille.uwo.ca, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue. Message-ID: <20140227164051.GA25183@kroah.com> References: <1393518402-24860-1-git-send-email-rs@mage.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1393518402-24860-1-git-send-email-rs@mage.me.uk> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 27, 2014 at 04:26:42PM +0000, Reza Snowdon wrote: > Fixed a coding style issue. > > Signed-off-by: Reza Snowdon > --- > drivers/staging/speakup/buffers.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/buffers.c b/drivers/staging/speakup/buffers.c > index 382973e..8d7caa7 100644 > --- a/drivers/staging/speakup/buffers.c > +++ b/drivers/staging/speakup/buffers.c > @@ -55,7 +55,8 @@ static int synth_buffer_free(void) > > int synth_buffer_empty(void) > { > - return (buff_in == buff_out); > + int buff_comparison = (buff_in == buff_out); > + return buff_comparison; What's wrong with the original code here? If anything, just drop the (), but really, it's fine, leave it alone, it's obvious what is happening is ok. thanks, greg k-h