Re: [PATCH 28/46] kernel: Add prototype declaration to header file linux/ftrace.h

Steven Rostedt
2014-02-27T19:56:28Z

On Thu, 27 Feb 2014 17:38:01 +0530
Rashika Kheria <rashika.kheria@gmail.com> wrote:

> Add prototye declaration of function to header file
> include/linux/ftrace.h
> because it is used by more than one file.
>
> This eliminates the following warning in
> kernel/trace/trace_functions_graph.c:
> kernel/trace/trace_functions_graph.c:218:15: warning: no previous prototype for ‘ftrace_return_to_handler’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
> include/linux/ftrace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index da1c31f..c4d1048 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -673,6 +673,7 @@ typedef void (*trace_func_graph_ret_t)(struct ftrace_graph_ret *); /* return */
> typedef int (*trace_func_graph_ent_t)(struct ftrace_graph_ent *); /* entry */
>
> int ftrace_graph_entry_stub(struct ftrace_graph_ent *trace);
> +unsigned long ftrace_return_to_handler(unsigned long frame_pointer);

Like ftrace_graph_entry_stub() this too is only called from assembly.
Just make the comment I asked to add apply to both of them.

-- Steve

>
> #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>