Re: [PATCH 11/46] kernel: Add prototype declaration in kernel/gcov/base.c

Peter Oberparleiter
2014-02-28T09:39:05Z

On 27.02.2014 12:39, Rashika Kheria wrote:
> Add prototype declarations of functions in kernel/gcov/base.c. These
> functions are required by GCC builtins and hence can not be removed
> despite of their unreferenced appearance in kernel source.
>
> This eliminates the following warning in kernel/gcov/base.c:
> kernel/gcov/base.c:30:6: warning: no previous prototype for ‘__gcov_init’ [-Wmissing-prototypes]
> kernel/gcov/base.c:58:6: warning: no previous prototype for ‘__gcov_flush’ [-Wmissing-prototypes]
> kernel/gcov/base.c:64:6: warning: no previous prototype for ‘__gcov_merge_add’ [-Wmissing-prototypes]
> kernel/gcov/base.c:70:6: warning: no previous prototype for ‘__gcov_merge_single’ [-Wmissing-prototypes]
> kernel/gcov/base.c:76:6: warning: no previous prototype for‘__gcov_merge_delta’ [-Wmissing-prototypes]
> kernel/gcov/base.c:82:6: warning: no previous prototype for ‘__gcov_merge_ior’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Acked-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>

> ---
> kernel/gcov/base.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/kernel/gcov/base.c b/kernel/gcov/base.c
> index f45b75b..c0cb53a 100644
> --- a/kernel/gcov/base.c
> +++ b/kernel/gcov/base.c
> @@ -27,6 +27,7 @@ static DEFINE_MUTEX(gcov_lock);
> * __gcov_init is called by gcc-generated constructor code for each object
> * file compiled with -fprofile-arcs.
> */
> +void __gcov_init(struct gcov_info *info);
> void __gcov_init(struct gcov_info *info)
> {
> static unsigned int gcov_version;
> @@ -55,30 +56,35 @@ EXPORT_SYMBOL(__gcov_init);
> * These functions may be referenced by gcc-generated profiling code but serve
> * no function for kernel profiling.
> */
> +void __gcov_flush(void);
> void __gcov_flush(void)
> {
> /* Unused. */
> }
> EXPORT_SYMBOL(__gcov_flush);
>
> +void __gcov_merge_add(gcov_type *counters, unsigned int n_counters);
> void __gcov_merge_add(gcov_type *counters, unsigned int n_counters)
> {
> /* Unused. */
> }
> EXPORT_SYMBOL(__gcov_merge_add);
>
> +void __gcov_merge_single(gcov_type *counters, unsigned int n_counters);
> void __gcov_merge_single(gcov_type *counters, unsigned int n_counters)
> {
> /* Unused. */
> }
> EXPORT_SYMBOL(__gcov_merge_single);
>
> +void __gcov_merge_delta(gcov_type *counters, unsigned int n_counters);
> void __gcov_merge_delta(gcov_type *counters, unsigned int n_counters)
> {
> /* Unused. */
> }
> EXPORT_SYMBOL(__gcov_merge_delta);
>
> +void __gcov_merge_ior(gcov_type *counters, unsigned int n_counters);
> void __gcov_merge_ior(gcov_type *counters, unsigned int n_counters)
> {
> /* Unused. */
>

--
Peter Oberparleiter
Linux on System z Development - IBM Germany