Re: [PATCH 27/46] kernel: Mark function as static in kernel/trace/trace_selftest.c

Steven Rostedt
2014-02-27T19:54:28Z

On Thu, 27 Feb 2014 17:36:41 +0530
Rashika Kheria <rashika.kheria@gmail.com> wrote:

> Mark function as static in kernel/trace/trace_selftest.c because it is
> not used outside this file.
>
> This eliminates the following warning in kernel/trace/trace_selftest.c:
> kernel/trace/trace_selftest.c:318:5: warning: no previous prototype for ‘trace_selftest_startup_dynamic_tracing’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
> kernel/trace/trace_selftest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c
> index e98fca6..bfecd63 100644
> --- a/kernel/trace/trace_selftest.c
> +++ b/kernel/trace/trace_selftest.c
> @@ -315,9 +315,9 @@ static int trace_selftest_ops(int cnt)
> }
>
> /* Test dynamic code modification and ftrace filters */
> -int trace_selftest_startup_dynamic_tracing(struct tracer *trace,
> - struct trace_array *tr,
> - int (*func)(void))
> +static int trace_selftest_startup_dynamic_tracing(struct tracer *trace,
> + struct trace_array *tr,
> + int (*func)(void))
> {
> int save_ftrace_enabled = ftrace_enabled;
> unsigned long count;