Re: [PATCH 29/46] kernel: Mark functions as static in trace/trace_functions_graph.c

Steven Rostedt
2014-02-27T19:57:46Z

On Thu, 27 Feb 2014 17:40:11 +0530
Rashika Kheria <rashika.kheria@gmail.com> wrote:

> Mark functions as static in kernel/trace/trace_functions_graph.c because
> they are not used outside this file.
>
> This eliminates the following warning in
> kernel/trace/trace_functions_graph.c:
> kernel/trace/trace_functions_graph.c:333:5: warning: no previous prototype for ‘trace_graph_thresh_entry’ [-Wmissing-prototypes]
> kernel/trace/trace_functions_graph.c:422:6: warning: no previous prototype for ‘trace_graph_thresh_return’ [-Wmissing-prototypes]
> kernel/trace/trace_functions_graph.c:1408:6: warning: no previous prototype for ‘print_graph_headers’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
> kernel/trace/trace_functions_graph.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 0b99120..9e9b5c2 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -330,7 +330,7 @@ int trace_graph_entry(struct ftrace_graph_ent *trace)
> return ret;
> }
>
> -int trace_graph_thresh_entry(struct ftrace_graph_ent *trace)
> +static int trace_graph_thresh_entry(struct ftrace_graph_ent *trace)
> {
> if (tracing_thresh)
> return 1;
> @@ -419,7 +419,7 @@ void set_graph_array(struct trace_array *tr)
> smp_mb();
> }
>
> -void trace_graph_thresh_return(struct ftrace_graph_ret *trace)
> +static void trace_graph_thresh_return(struct ftrace_graph_ret *trace)
> {
> if (tracing_thresh &&
> (trace->rettime - trace->calltime < tracing_thresh))
> @@ -1405,7 +1405,7 @@ static void __print_graph_headers_flags(struct seq_file *s, u32 flags)
> seq_printf(s, " | | | |\n");
> }
>
> -void print_graph_headers(struct seq_file *s)
> +static void print_graph_headers(struct seq_file *s)
> {
> print_graph_headers_flags(s, tracer_flags.val);
> }