Re: [PATCH 04/46] kernel: Mark function as static in kernel/resource.c

Yasuaki Ishimatsu
2014-02-27T12:14:35Z

(2014/02/27 20:14), Rashika Kheria wrote:
> Mark function as static in kernel/resource.c because it is not used
> outside this file.
>
> This eliminates the following warning in kernel/resource.c:
> kernel/resource.c:518:5: warning: no previous prototype for ‘reallocate_resource’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---

Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

Thanks,
Yasuaki Ishimatsu

> kernel/resource.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3f285dc..ede7db2 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -515,9 +515,9 @@ static int find_resource(struct resource *root, struct resource *new,
> * @newsize: new size of the resource descriptor
> * @constraint: the size and alignment constraints to be met.
> */
> -int reallocate_resource(struct resource *root, struct resource *old,
> - resource_size_t newsize,
> - struct resource_constraint *constraint)
> +static int reallocate_resource(struct resource *root, struct resource *old,
> + resource_size_t newsize,
> + struct resource_constraint *constraint)
> {
> int err=0;
> struct resource new = *old;
>