Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

Peter Zijlstra
2014-02-27T19:24:42Z

On Thu, Feb 27, 2014 at 08:03:22AM -0800, Josh Triplett wrote:
> On Thu, Feb 27, 2014 at 12:58:05PM +0100, Peter Zijlstra wrote:
> > On Thu, Feb 27, 2014 at 05:20:19PM +0530, Rashika Kheria wrote:
> > > @@ -5266,7 +5266,7 @@ static unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu)
> > > return smt_gain;
> > > }
> > >
> > > -unsigned long __weak arch_scale_smt_power(struct sched_domain *sd, int cpu)
> > > +static unsigned long arch_scale_smt_power(struct sched_domain *sd, int cpu)
> > > {
> > > return default_scale_smt_power(sd, cpu);
> > > }
> >
> > Fuck no; please think before sending.
> >
> > I'm going to ignore all patches from you henceforth.
>
> Did you perhaps check, and notice that there are *zero* uses of this
> function in the kernel? Nothing overrides this weak symbol; it is no
> longer needed. You removed the one and only user in your commit:

I know that; but you don't get to remove interfaces under the guise of a
static checker and without mention of such in the changelog.

You should bloody well know better.