Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

Josh Triplett
2014-02-27T16:03:34Z

On Thu, Feb 27, 2014 at 12:58:05PM +0100, Peter Zijlstra wrote:
> On Thu, Feb 27, 2014 at 05:20:19PM +0530, Rashika Kheria wrote:
> > @@ -5266,7 +5266,7 @@ static unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu)
> > return smt_gain;
> > }
> >
> > -unsigned long __weak arch_scale_smt_power(struct sched_domain *sd, int cpu)
> > +static unsigned long arch_scale_smt_power(struct sched_domain *sd, int cpu)
> > {
> > return default_scale_smt_power(sd, cpu);
> > }
>
> Fuck no; please think before sending.
>
> I'm going to ignore all patches from you henceforth.

Did you perhaps check, and notice that there are *zero* uses of this
function in the kernel? Nothing overrides this weak symbol; it is no
longer needed. You removed the one and only user in your commit:

commit ee08d1284ea9235b29bd2d9b7493b4b4cf3da09c
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Wed Jun 13 15:24:45 2012 +0200

sched/x86: Remove broken power estimation

The x86 sched power implementation has been broken forever and gets in
the way of other stuff, remove it.

When I reviewed Rashika's patch and provided a Reviewed-by, I provided
the following feedback:

Josh Triplett wrote:
> I'd suggest waiting to see how the scheduler folks respond to this patch
> series, and then if they accept the changes marking unused __weak
> functions as static, you could follow up with a patch that folds them
> into their callers and gets rid of them entirely.

(That feedback was based on the assumption that the simplest possible
mark-it-static patch would be a good starting point.)

Now, given all of the above, perhaps you could provide some useful
feedback on what you find so objectionable about this patch?

- Josh Triplett