Re: [PATCH 36/46] kernel: Mark functions as static in kernel/tracepoint.c

Mathieu Desnoyers
2014-02-27T13:40:06Z

----- Original Message -----
> From: "Rashika Kheria" <rashika.kheria@gmail.com>
> To: linux-kernel@vger.kernel.org
> Cc: "Rashika Kheria" <rashika.kheria@gmail.com>, "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Sasha Levin"
> <sasha.levin@oracle.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Paul E. McKenney"
> <paulmck@linux.vnet.ibm.com>, "Sahara" <keun-o.park@windriver.com>, josh@joshtriplett.org
> Sent: Thursday, February 27, 2014 7:20:47 AM
> Subject: [PATCH 36/46] kernel: Mark functions as static in kernel/tracepoint.c
>
> Mark functions as static in kernel/tracepoint.c because they are not
> used outside this file.
>
> This eliminates the following warning in kernel/tracepoint.c:
> kernel/tracepoint.c:326:6: warning: no previous prototype for
> ‘module_update_tracepoints’ [-Wmissing-prototypes]
> kernel/tracepoint.c:702:5: warning: no previous prototype for
> ‘tracepoint_module_notify’ [-Wmissing-prototypes]

Yes, this needs to be fixed. However, I recommend to simply queue
this cleanup for 3.15 (no -stable backport), as it is not fixing
anything critical.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
> kernel/tracepoint.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
> index 29f2654..0e26255 100644
> --- a/kernel/tracepoint.c
> +++ b/kernel/tracepoint.c
> @@ -323,7 +323,7 @@ static void tracepoint_update_probe_range(struct
> tracepoint * const *begin,
> }
>
> #ifdef CONFIG_MODULES
> -void module_update_tracepoints(void)
> +static void module_update_tracepoints(void)
> {
> struct tp_module *tp_mod;
>
> @@ -332,7 +332,7 @@ void module_update_tracepoints(void)
> tp_mod->tracepoints_ptrs + tp_mod->num_tracepoints);
> }
> #else /* CONFIG_MODULES */
> -void module_update_tracepoints(void)
> +static void module_update_tracepoints(void)
> {
> }
> #endif /* CONFIG_MODULES */
> @@ -699,7 +699,7 @@ static int tracepoint_module_going(struct module *mod)
> return 0;
> }
>
> -int tracepoint_module_notify(struct notifier_block *self,
> +static int tracepoint_module_notify(struct notifier_block *self,
> unsigned long val, void *data)
> {
> struct module *mod = data;
> --
> 1.7.9.5
>
>

--
Mathieu Desnoyers
EfficiOS Inc.