Re: [PATCH 26/46] kernel: Mark functions as static in kernel/trace/trace.c

Steven Rostedt
2014-02-27T19:43:07Z

On Thu, 27 Feb 2014 17:33:53 +0530
Rashika Kheria <rashika.kheria@gmail.com> wrote:

> Mark functions as static in kernel/trace/trace.c
> because they are not used outside this file.
>
> This eliminates the following warning in kernel/trace/trace.c:
> kernel/trace/trace.c:266:9: warning: no previous prototype for ‘buffer_ftrace_now’ [-Wmissing-prototypes]
> kernel/trace/trace.c:590:6: warning: no previous prototype for ‘free_snapshot’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
> kernel/trace/trace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 815c878..f097949 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -263,7 +263,7 @@ int call_filter_check_discard(struct ftrace_event_call *call, void *rec,
> }
> EXPORT_SYMBOL_GPL(call_filter_check_discard);
>
> -cycle_t buffer_ftrace_now(struct trace_buffer *buf, int cpu)
> +static cycle_t buffer_ftrace_now(struct trace_buffer *buf, int cpu)
> {
> u64 ts;
>
> @@ -587,7 +587,7 @@ static int alloc_snapshot(struct trace_array *tr)
> return 0;
> }
>
> -void free_snapshot(struct trace_array *tr)
> +static void free_snapshot(struct trace_array *tr)
> {
> /*
> * We don't free the ring buffer. instead, resize it because