Re: [PATCH 1/1] affs: AFFS_NO_TRUNCATE added to Kconfig

Fabian Frederick
2014-03-03T20:55:11Z

On Mon, 3 Mar 2014 14:43:27 -0500
Dave Jones <davej@redhat.com> wrote:

> On Mon, Mar 03, 2014 at 06:22:18PM +0800, Fabian Frederick wrote:
> > Filename truncate process is defined in affs.h.
> >
> > This patch exports current define to Kconfig and removes
> > AFFS_MAX_PREALLOC which is never used.
> > +
> > +config AFFS_NO_TRUNCATE
> > + bool "Amiga FFS no filename truncate"
> > + depends on AFFS_FS
> > + default n
> > + help
> > + If you say Y here, creating filesystem objects with longer names than
> > + 30 characters (standard limit) will result in an error (ENAMETOOLONG).
> > +
> > + By default this option is disabled and filenames are automatically
> > + truncated.
>
> I get the feeling this would be better as a mount option than a config option.
> Then again, the number of people still caring about AFFS is probably in
> single digits these days, so I doubt anyone would complain if this was set
> one way or the other in a distribution kernel.

Good idea but I guess this would need passing sbi->s_flags to affs_check_name which would require some more updates ...

Fabian

>
> Dave
>