From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
"Theodore T'so" <tytso@mit.edu>, Christoph Hellwig <hch@lst.de>,
Chris Mason <clm@fb.com>, Dave Chinner <david@fromorbit.com>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
"J. Bruce Fields" <bfields@citi.umich.edu>,
Yongzhi Pan <panyongzhi@gmail.com>
Subject: Re: Update of file offset on write() etc. is non-atomic with I/O
Date: Mon, 3 Mar 2014 21:45:36 +0000 [thread overview]
Message-ID: <20140303214536.GK18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFy4GvpFcboBiKdreU_Zh1RzynPoLxhvC9hijn60hkEZ3g@mail.gmail.com>
On Mon, Mar 03, 2014 at 09:36:58AM -0800, Linus Torvalds wrote:
> +static struct fd fdget_pos(int fd)
> +{
> + struct fd f = fdget(fd);
> + struct file *file = f.file;
> +
> + if (file && (file->f_mode & FMODE_ATOMIC_POS)) {
> + if (f.need_put || file_count(file) > 1) {
Um... That's odd - we *could* get there with f.need_put and
file_count(file) equal to 1, but why would we want to take
f_pos_lock in that case?
And it looks like you've missed compat counterparts. Other than
that, it'd probably work... Let me check if there are other
paths we might need to take care of, though.
PS: apologies for being pretty much MIA for the last two weeks; I'd been
ears-deep in interesting scalability crap around vfsmount handling ;-/
Will post the resulting patches for review shortly...
next prev parent reply other threads:[~2014-03-03 21:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:41 Update of file offset on write() etc. is non-atomic with I/O Michael Kerrisk (man-pages)
2014-02-18 13:00 ` Michael Kerrisk
2014-02-20 17:14 ` Linus Torvalds
2014-03-03 17:36 ` Linus Torvalds
2014-03-03 21:45 ` Al Viro [this message]
2014-03-03 21:56 ` Linus Torvalds
2014-03-03 22:09 ` Al Viro
2014-03-03 22:20 ` Linus Torvalds
2014-03-03 22:01 ` Linus Torvalds
2014-03-03 22:10 ` Al Viro
2014-03-03 22:22 ` Linus Torvalds
2014-03-06 15:03 ` Michael Kerrisk (man-pages)
2014-03-07 3:38 ` Yongzhi Pan
[not found] <a8df285f-de7f-4a3a-9a19-e0ad07ab3a5c@blur>
2014-02-20 18:15 ` Zuckerman, Boris
2014-02-20 18:29 ` Al Viro
2014-02-21 6:01 ` Michael Kerrisk (man-pages)
2014-02-23 1:18 ` Kevin Easton
2014-02-23 7:38 ` Michael Kerrisk (man-pages)
-- strict thread matches above, loose matches on Subject: below --
2014-03-03 21:03 George Spelvin
2014-03-03 21:26 ` Al Viro
2014-03-03 21:52 ` Linus Torvalds
2014-03-03 22:01 ` Al Viro
2014-03-03 22:17 ` Linus Torvalds
2014-03-03 23:28 ` Al Viro
2014-03-03 23:34 ` Linus Torvalds
2014-03-03 23:42 ` Al Viro
2014-03-03 23:59 ` Linus Torvalds
2014-03-04 0:23 ` Al Viro
2014-03-04 0:42 ` Linus Torvalds
2014-03-04 1:05 ` Al Viro
2014-03-04 20:00 ` Al Viro
2014-03-04 21:17 ` Linus Torvalds
2014-03-05 0:04 ` Al Viro
2014-03-10 15:55 ` Al Viro
2014-03-03 22:55 ` Linus Torvalds
2014-03-03 23:23 ` Linus Torvalds
2014-03-03 23:39 ` Al Viro
2014-03-03 23:54 ` Linus Torvalds
2014-03-03 23:54 ` Al Viro
2014-03-04 20:11 ` Cedric Blancher
2014-03-04 0:07 ` George Spelvin
2014-05-04 7:04 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303214536.GK18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@citi.umich.edu \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mtk.manpages@gmail.com \
--cc=panyongzhi@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox