From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755805AbaCCXjG (ORCPT ); Mon, 3 Mar 2014 18:39:06 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:36714 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755326AbaCCXjE (ORCPT ); Mon, 3 Mar 2014 18:39:04 -0500 Date: Mon, 3 Mar 2014 23:39:02 +0000 From: Al Viro To: Linus Torvalds Cc: George Spelvin , linux-fsdevel , Linux Kernel Mailing List Subject: Re: Update of file offset on write() etc. is non-atomic with I/O Message-ID: <20140303233902.GP18016@ZenIV.linux.org.uk> References: <20140303210359.26624.qmail@science.horizon.com> <20140303212642.GJ18016@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 03, 2014 at 03:23:55PM -0800, Linus Torvalds wrote: > This just uses a "flags" field, and we currently only have two bits > that we use: FDPUT_FPUT and FDPUT_POS_UNLOCK. The first patch knows > that "fget_light()" writes 0/1 for that, which is the same as the > FDPUT_FPUT bit. I didn't bother to comment on it or clean it up, since > the second patch just removes that whole fget_light() mess. > > Comments? do_sendfile() is also there and this one is even more unpleasant ;-/ We probably can ignore that one (until POSIX learns of its existence), thouhg...